[MovieSelection] Show extended description doesn't switch off cleanly

Issue #565 resolved
prl created an issue

If MEDIA, MENU>Settings>Show extended description is set to "no", the first time MovieSelection is entered after a GUI restart (MEDIA from live TV), the extended description of the initially selected recording is shown. Navigating between entries in MovieSelection doesn't change or clear the extended description. EXIT from MovieSelection and then re-enter it with MEDIA, and the extended description is correctly not shown.

If MEDIA, MENU>Settings>Show extended description is set to "yes", and then switched back to "no", when MoviePlayer is re-entered from MEDIA, MENU>Settings, the extended description of the initially selected recording is shown. Navigating between entries in MovieSelection doesn't change or clear the extended description. EXIT from MovieSelection and then re-enter it with MEDIA, and the extended description is correctly not shown.

The cause of the bug is that the __selectionChanged() callback in SelectionEventInfo.onShown is called earlier than it appears that the software author expected, before MovieSelection.settings["description"] has been set to the correct value.

Replication steps

From live TV, MEDIA, MENU>Settings, and set Show extended description to "no".

Before exiting the media player selection screen, navigate to a recording using UP/DOWN.

Return to live TV and long-POWER>Restart GUI.

When the GUI has restarted, MEDIA to enter the media player selection screen. The extended description of the initially selected show is displayed. Navigating with UP/DOWN doesn't change the description.

EXIT, MEDIA to return to live TV and then re-enter the media player selection screen.

The extended description is now correctly not displayed.

While still in the media player selection screen, MENU>Settings, set Show extended description to "yes", then EXIT to return to the selection screen. The extended description is displayed, and changes as expected when UP/DOWN is used to navigate.

Remaining in the media player selection screen, MENU>Settings, set Show extended description to "no", then EXIT to return to the selection screen. The extended description of the initially selected show is displayed. Navigating with UP/DOWN doesn't change the description.

EXIT, MEDIA to return to live TV and then re-enter the media player selection screen.

The extended description is now correctly not displayed.

Comments (2)

  1. Peter Urbanec

    Fix bug #565: [MovieSelection] Show extended description doesn't switch off cleanly

    [SelectionEventInfo]

    Move the test on the state of MovieList.settings["description"] from __selectionChanged() to updateEventInfo() so that the test is deferred to when MovieList.settings["description"] has been updated.

    → <<cset e107cba220bd>>

  2. Log in to comment