"Configure backups" can cause some backups to be missed

[prl]

In both ConfigLocation.load() and Components.FileList.MultiFileSelectList.getSelectedList() files are eliminated from the file list if they don't exist.

That means that if BackupSelection modifies config.plugins.configurationbackup.backupdirs, all files in backupdirs that don't exist are removed from backupdirs. That includes all default backup full path entries that don't exist, and all entries that contain "*?[]" filename expansions, whether they would match files or not.

That means that after modifying backupdirs none of the backups that contain expansion characters will get backed up any more, and if files are added that would otherwise be backed up in the default set of backups, they won't be backed up unless the user adds them manually.

Replication steps

In MENU>Setup>Software manager>Configure backups (or PLUGIN>Software management>Advanced options>Select backup files), select an additional file to be backed up (e.g. /etc/autofs.conf).

GREEN Save

Then restart the GUI to save config.plugins.configurationbackup.backupdirs.

When restarted, examine /etc/enigma2/settings for the value of config.plugins.configurationbackup.backupdirs. It will no longer contain /etc/wpa_supplicant.conf or /etc/ssh/ssh_host_ (and some other paths in the defaults may also be missing).

[Peter Urbanec]

Fix Bug #596: "Configure backups" can cause some backups to be missed

Add keepNonexistentFiles optional parameter to MultiFileSelectList.init() and keep_nonexistent_files optional parameter to ConfigLocations.init(). When set, MultiFileSelectList.getSelectedList() and ConfigLocations.load() don't remove locationss that don't exist from the location list.

The two new parameters default to False too preserve the bahaviour of other uses of the classes.

→ <<cset 4b5604e63be3>>

[Peter Urbanec]

Merged in prl/easy-ui-4/Fix-bug-596 (pull request #371)

Fix Bug #596: "Configure backups" can cause some backups to be missed

→ <<cset f83a5504c845>>