Both lists showing as selected in FileCommander multi-select

Issue #659 resolved
prl created an issue

When multi-select mode is entered in the FileCommander, both the left and right lists are shown with selection highlighting, even though only one of them is actually active.

If CH+/- or PREV/NEXT is used to switch between the lists the selection highlighting is corrected and shows only the selection highlighting on the correct list.

The problem is due to the fact that FileCommanderScreenFileSelect calls self.listLeft() or self.listRight() in __init___(), but at that time there are no instances associated with the FileLists, so the calls to selectionEnabled() in the methods are ineffective.

FileCommanderScreen correctly defers the calling of self.listLeft() or self.listRight() to self.onLayout().

Replication steps

From live TV, MENU>Sources/Files.

MEDIA to enter multi-select mode.

The first entry in both lists shows selection highlighting.

CH+/- or PREV/NEXT to switch between lists: selection highlighting only shown on the correct list.

Comments (1)

  1. Peter Urbanec

    Fix bug #659: Both lists showing as selected in FileCommander multi-select

    Defer calling self.listLeft() and self.listRight() until onLayoutFinish so that the file lists have had their widget instances created and the calls to the lists' selectionEnabled() methods can have an effect.

    → <<cset 6992281a7b08>>

  2. Log in to comment