MovieSelection sometimes sets all configurable buttons to add AutoTimer

[prl]

If the settings screen in the media selection screen is entered and then exited without making any changes or moving the focus, all the user-configured buttons are set to "add AutoTimer" and all the coloured button hints show "add AutoTimer" in their labels.

A side-effect of the bug is that it can place entries for the button configurations in /etc/enigma2/settings for buttons that have their default settings.

Another is that on cancelling the media selection settings screen with EXIT or RED, the user is asked whether they want to save settings, even when no settings have been changed.

The cause is that when updateUserDefinedActions calls btn.setChoices() it needs to supply a valid default parameter value and it doesn't.

Replication steps

From live TV: MEDIA, MENU>Settings, EXIT, "yes" to exit without saving settings: all buttons now show "add AutoTimer".

[Peter Urbanec]

Fix bug #664: MovieSelection sometimes sets all configurable buttons to add AutoTimer

In MovieSelection.updateUserDefinedActions() change the call of btn.setChoices() to include default=btn.default so that the selection retains the correct default.

Also, initialise and update the configurable button ConfigSelections with copies of the selection list to avoid potential future issues with aliasing between the selection lists in different ConfigSelections.

→ <<cset 6439ef565017>>