[IceTV] Final processing in doWork() not done if getShows() fails

Issue #712 resolved
prl created an issue

In the IceTV plugin's EPGFetcher.doWork(), if the call of self.getShows() throws an exception, the code

            self.addLog("End update")
            self.deferredPostStatus(None)
            self.statusCleanup()

is not run, and it is not replicated in the code that execution falls through to if the exception is caught.

That means that if self.getShows() throws an exception, processing and cleanup of some of the deferred status change reports to IceTV will be delayed until the next time self.getShows() runs.

Replication steps

By code examination.

Comments (1)

  1. Peter Urbanec

    Fix Bug #712: [IceTV] Final processing in doWork() not done if getShows() fails

    In EPGFetcher.doWork(), execute self.addLog("End update") self.deferredPostStatus(None) self.statusCleanup() just before the final return in the method so that the "End update" message is shown and the deferred recording status processing is done in cases where a handled exception is thrown in the try block surrounding the call of self.getShows().

    → <<cset d5ec4e90045d>>

  2. Log in to comment