- changed status to resolved
[IceTV] - error message cleanup
When otherwise unhandled exceptions are handled by _logResponseException()
, the error message displayed is simply the stringified Exception
. If the exception is ConnectionError
, a more informative introduction is printed, but the actual error message is still the Exception
as a string.
It would be more user-friendly to extract relevant information from the Exception
and display that wherever possible, but particularly for ConnectionError
where the underlying error can be extracted from the stringified exception and for other RequestException
exceptions that contain an explicit JSON response from IceTV.
Where more user-friendly error information can be extracted, the stringified Exception
should still be sent to the IceTV (and debug) log, and if user-friendly can’t be extracted, it can fall back to only showing the stringified Exception
.
I have an tested implementation ready to submit.
Comments (2)
-
reporter -
reporter Merged in Fix-issue-766 (pull request #680)
Fix issue
#766: [IceTV] - error message cleanup→ <<cset 568ced2563d6>>
- Log in to comment
Fix issue
#766: [IceTV] - error message cleanup[IceTV]
In _logResponseException(), give more user-friendly error messages for ConnectionError and for other RequestExceptions by extracting the underlying error message for ConnectionError and displaying the IceTV JSON error information where it exists in other RequestExceptions.
Log both the user-friendly error message (where it exists) and the stringified Exception to the IceTV and debug logs.
Bump version number.
→ <<cset f50477792f71>>