[IceTV] Error popups sometimes fail

Issue #772 resolved
prl created an issue

When error messages are constructed by _logResponseException() in plugin.py, and used in a MessageBox popup in IceTVNeedPassword.doLogin(), no text is sometimes displayed in the popup.

This is because in the changes to port the IceTV plugin to OpenViX, six.ensure_text() was used in _logResponseException() where six.ensure_str() should have been used, and in Python2 systems, the MessageBox is passed a unicode object rather than a str.

Replication steps

Open the IceTV login screen, MENU>IceTV>Login to IceTV server.

If it isn’t empty already, clear the Password field, then press GREEN Login.

An error popup will display, but it will contain no text, and will only display the upper art of the error icon.

Comments (2)

  1. prl reporter

    Fix issue #772: [IceTV] Error popups sometimes fail

    [plugin]

    Use six.ensure_str() instead of six.ensure_text() in _logResponseException() when fetching IceTV error messages.

    [API]

    Bump version number

    → <<cset e0eef928a480>>

  2. Log in to comment