- changed status to open
Copying a community post fails
If you try to copy a community post via the post buttons on http://www.bibsonomy.org/discussed, the procedure fails. However, if you select the post first and THEN copy it, everything is fine. Please make sure that the buttons work correctly.
Comments (14)
-
-
- marked as minor
-
- changed version to 2.0.44
-
Account Deleted - changed status to resolved
fixed issue
#1923by using inter- instead of intra-hash.→ <<cset 93add736365f>>
-
- changed status to open
It is a not so good heuristic to use in all cases the inter hash. In the worst case the user copies a post he does not want to copy. Please fix this.
-
Account Deleted This had been the behavior of the copy-button at the details page! cf. http://www.biblicious.org/bibtex/16f78177742b3c836218aacfc7fc4c43c
However, copying a community post submitting the inter-hash works, using the intra-hash does not. Copying a post from e.g. Home page operates vice-versa...
-
Yes, but without a username, hence you copy the community post on the community post site. You modified the general action tagx file which is also used on all other sites, e.g. http://www.biblicious.org. Using the interhash in this case with the username can result in copying the wrong post from the user (assumed the user has two post with the same interhash). Actually the logic will no longer find anything because the intrahash does not equal the interhash, and the user does not have any post with the interhash as intrahash.
-
Account Deleted So, why using the inter-hash for community posts, anyhow?
-
Because the interhash (without username) uniquely identifies a community post by convention and the username and intrahash combo a normal post.
In the action tagx you must check if the post is a community entry. In this case use the interhash only, otherwise the intrahash and username.
-
Account Deleted - changed status to resolved
fixed issue
#1923: use intrahash or interhash, as the case may be, in order to identify a non-community or community post, respectively.→ <<cset 273f2f673202>>
-
reporter Can confirm. Tested this with the locally compiled branch. Merging into default.
-
- changed status to open
Does not work with bookmarks of community posts. Please add the appropriate behavior for bookmarks too. Currently, an exception Internal Server Error: java.lang.RuntimeException: SimHash 2 doesn't exist is thrown.
-
Account Deleted This does not depend on using either interhash or intrahash. Same exception is thrown at bibsonomy.org copying a community post, still using the intrahash.
→ See Issue
#1964. -
Account Deleted - changed status to closed
The initial issue by Thomas is already fixed (see above); Issue
#1964covers Stephan's (second) bug. - Log in to comment