- changed status to open
Redundant check in dicomCodec::allocChannels
Issue #138
closed
The following line code:
if(channelNum == 0)
newChannel->m_samplingFactorX = samplingFactorX;
contains a redundant check. If channelNum is different than zero then samplingFactorX will be 1, and therefore can be safely assigned to the channel anyway (which already has samplingFactorX=1 by default).
Therefore the code could simply be:
newChannel->m_samplingFactorX = samplingFactorX;
Comments (4)
-
reporter -
reporter - changed status to resolved
- Resolves
#138(Redundant check in dicomCodec::allocChannels) as per SOP DEVENH/1
→ <<cset e2eb40c87e28df09eedce78ce3f36f8449488241>>
-
reporter - Resolves
#138(Redundant check in dicomCodec::allocChannels) as per SOP DEVENH/1 (grafted from e2eb40c87e28df09eedce78ce3f36f8449488241)
→ <<cset 3ac27f27e8773c9343cf482aa59af02abfa82905>>
- Resolves
-
reporter - changed status to closed
Fixed in 4.0.5.1
- Log in to comment