pyp2rpm should add BR for python-setuptools automatically

Issue #15 resolved
Jens Petersen created an issue

I think a lot of python/pip packages use setuptools to build and so their spec files need a BR for python-setuptools to build in buildroots (mock, koji, etc).

It should not be too difficult to detect (guess?) when it is needed and add the BR automatically, I think.

Comments (5)

  1. Robert Kuska

    pyp2rpm is getting (build) requires for packages from metadata of (pypi) packages, if setuptools are listed as setup requires than they should be added to spec.

    I don't really know how it should work otherwise, checking imports in files? I am open to suggestions (or PRs) to improve dependencies detection.

  2. Slavek Kabrda repo owner

    It'd be great to come up with a smart way to detect if setuptools are required. However if we don't find such a way, I'd probably vote for buildrequiring setuptools always, since they are needed more often than not and they don't add any more dependencies to install to the buildroot.

  3. Log in to comment