pyp2rpm should add BR for python-setuptools automatically
I think a lot of python/pip packages use setuptools to build and so their spec files need a BR for python-setuptools to build in buildroots (mock, koji, etc).
It should not be too difficult to detect (guess?) when it is needed and add the BR automatically, I think.
Comments (5)
-
-
-
assigned issue to
-
assigned issue to
-
repo owner It'd be great to come up with a smart way to detect if setuptools are required. However if we don't find such a way, I'd probably vote for buildrequiring setuptools always, since they are needed more often than not and they don't add any more dependencies to install to the buildroot.
-
repo owner (It also occured to me that packages may need setuptools in runtime, if they use entrypoints, so I opened another bug for this: https://bitbucket.org/bkabrda/pyp2rpm/issue/16/pyp2rpm-should-add-r-python-setuptools-if)
-
- changed status to resolved
Add setuptools to BuildRequires by default fixes
#15→ <<cset ed46866d894d>>
- Log in to comment
pyp2rpm is getting (build) requires for packages from metadata of (pypi) packages, if setuptools are listed as setup requires than they should be added to spec.
I don't really know how it should work otherwise, checking imports in files? I am open to suggestions (or PRs) to improve dependencies detection.