devPanel overlays UI in Sleek theme

Issue #190 resolved
Oliver Salzburg created an issue

With the Sleek theme enabled, the #devPanel will overlay the Bonfire button partially. This is highly annoying.

When I looked into this, I noticed this piece of code: https://bitbucket.org/bloodrizer/kitten-game/src/49f3a289acfa97f812dd516871935f8e65125c76/index.html#lines-314

I don’t understand what this code is trying to achieve. Especially since the function hints that it’s supposed to affect the game log, not the dev panel. By setting the height on the invisible devPanel, the problematic overlay is created.

Comments (1)

  1. Arima B. repo owner

    fix: Remove height adjustment code

    This code currently messes with the dev panel needlessly. The dev panel looks perfectly fine without it. The code was originally (8 years ago) intended to size the game log. Today the game log is set to fill 100% of the available height anyway and this code seems completely redundant.

    Fixes #190

    → <<cset b90d8cf492e9>>

  2. Log in to comment