1. Christian Fibich Avatar Christian Fibich
  2. Untitled project
  3. OJOC
  4. Issues

Refactor OJOC.py

Issue #4 new
Christian Fibich repo owner created an issue

Refactor OJOC.py to reduce amount of Copy/Paste

Comments (4)

  1. Jacob Karlsson

    I'm really feeling like poking around in the code (no promises) but these variable names are absolutely cryptic. Instead of me going through, figuring out what they all actually mean it'd be great if you could go through the code and make it a little bit more understandable since I hope at least you still remember what they mean :)
    https://programmers.stackexchange.com/questions/33349/scientific-evidence-that-supports-using-long-variable-names-instead-of-abbreviat

  2. Jacob Karlsson

    Since I can't be bothered to make a fork yet I'll just note some more here:

    On arch, I needed the following packages (some in your list were already installed):
    python2-gobject
    python2-requests
    python2-keyring
    aur/python2-enum
    For others wondering what they have to install, just try launching the program and seeing what import statements fail.

    Also, since I didn't have a kde wallet, when I launched ojoc the splash screen showed and a dialog from the wallet came up asking me to set up encryption etc. After it being up for a bit the terminal started complaining and I wasn't able to exit it with c-c nor c-d. The second launch worked fine (so far).

    I also needed python2-urwid for nojoc.

  3. Christian Fibich reporter

    Thank you for your feedback! Refactoring the variable names and sprinkling a comment here and there is on my to-do list indeed, but it will take a few weeks.

  5. Log in to comment
Assignee
Type
proposal
Priority
minor
Status
new
Votes
0
Watchers
1
Jira: the preferred issue tracker for Bitbucket. Join the team!