Unify Login Buttons

[Jeremy Hopkins]

I just added more options for the login button for #112 but it could do with some improvement to the way styles are applied.

As the new login form setting puts a form into the header (see screen shot below) the requirements for styling are a little different, I found I needed a "height" setting.

However this setting has no use when the standard login button (really a html link) is used, similarly padding has little use when the login form is in use.

An improvement maybe to change the standard login button (a href) into a form button using method="get" which I think would allow us to have more consistent styles.

I will do this but wanted to get your thoughts as the button was initially your change.

[Info 3bits]

moodle still have many old code that should be modified but as you know the big elephant is getting more fat each time and less old bugs and problems are fixed. I didn't review the v3.0 code but I don't believe they updated old code to HTML5. So we need to deal with the old style probably for years.

The result is really good. The only question would be the bottom with the divider line. Probably above-header will need more pixels height. I tested 25px and looks well.

[Jeremy Hopkins]

Ok I will make your login button a form using "get" to the login page shortly

[Jeremy Hopkins]

Fix #124 (will require more work on styles later, perhaps remove padding option all together).

Fix #118 (bug in if statement)

→ <<cset 6e9a16a7917e>>

[Jeremy Hopkins]

Fix #124 (will require more work on styles later, perhaps remove padding option all together).

Fix #118 (bug in if statement)

→ <<cset 6e9a16a7917e>>