Deprecated function in renderers.php

[Info 3bits]

Get error:

The use of function error_log() is forbidden

in renderers.php when passing Code Checker:

https://bitbucket.org/covuni/moodle-theme_adaptable/src/02d2cbf9f8cb53e0b20f0f26d40c93ae8584756d/renderers.php?at=master&fileviewer=file-view-default#renderers.php-499

Now is commented but not sure what could happens.

[Jeremy Hopkins]

I am not exactly sure what this code is doing but think it is to do with being able to show "page loaded in x seconds" in the footer.

By default if you choose to show performance info in Moodle it will spit out several lines of information for different processes. In BCU we wanted to simply show "page loaded in x seconds" which essential (and now BCU / Adaptable) does.

The line you cide looks like it is to send performance info to the logs too, if it has been depricated I would assume Moodle core has another way of doing this now.

What I am not sure of is why that code would ever have been in the theme as core has settings to allow you to send debugging info to the logs, I think all the theme needed to do was parse the results going to the footer which is done in line 385 of lib.php

[Info 3bits]

Fix #239

→ <<cset b44199bf0e2c>>

[Info 3bits]

I think is an entry in the error log. So I would keep the lines commented and would try to find a workaround.