Messages pop-up notification spills out of the box

[Alexander Goryntsev]

As messages are now used for many kinds of notifications recently I've received this one regarding my forum activity. I guess it needs extended styling efforts that would improve the whole look of notifications besides this particular bug.

[Jeremy Hopkins]

I think we need to limit what that to only show messages between users. I am not sure how this works in Moodle now, one option would be to look at the way CUL Activity Stream works:

https://moodle.org/plugins/browse.php?list=set&id=68

which has a messages plugin allowing users to set what appears in the activity feed from their "notifications" page.

Personally I think we should just limit this to show only messages sent between users which was its original purpose.

[Alexander Goryntsev]

This issue is not limited to new types of notifications; usual messages also are not displayed correctly, see the screenshot. So if there is a dropdown even for messages only it has to be properly styled. Another bug linked to this issue surprisingly appears while switching a language.The second screenshot is for the same page - but in Russian. There is neither a dropdown menu nor a notification counter; the Russian label for 'messages' turns into a link to the messages page. A temporary solution for the issue would be removing a dropdown menu, fixing the counter for any language and turning the label into a link to the message page.

I am going to experiment with the Activity Stream plugin and share my thoughts.

IN ENGLISH

IN RUSSIAN

[Info 3bits]

You are right. I detected this problem in a test site.

Working on it.

[Info 3bits]

The main problem is that the dropdown display system messages like:

xxxxxxx has completed Test xxxxxx. See http://xxxxxxxxxxxxx

There are two option:

• Reduce the text adding br tags
• remove system messages from the list

[Jeremy Hopkins]

We should remove system messages from the list, they serve no useful purpose and make a mess.

[Info 3bits]

Linked to issue #300

[Info 3bits]

Issue #300 was marked as a duplicate of this issue.

[Jeremy Hopkins]

Fix #249 - increase message dropdown size to avoid spill. Correct issue with alignment caused by previous changes to user menu alignment.

→ <<cset cd8a8c51d696>>

[Jeremy Hopkins]

Alex, Fernando,

Could you take a look at the way the messages are displaying now. It needs some more work to pad the contents of the message dropdown. We may also need to limit the size of messages or adjust the size of the dropdown.

If Fernando looks at this commit the class to alter dropdown size will become clear.

[Jeremy Hopkins]

Fix #249 adding margins between profile image and time icon

→ <<cset 3b1f7265700a>>

[Alexander Goryntsev]

Hi, Jeremy!

That's what I'm getting on the messages dropdown pad. It certainly looks better but I think we need to use the full width of the dropdown pad or else the empty space to the right of the message looks weird. I notice that the messages on the screenshot are cut at different lengths so there is no fixed limit to display. Is it right?

Also there is a sitewide error with truncating Cyrillic words that results in this unnecessary symbol with a question mark that doesn't exist in the message text.