Settings relating to site title and course name display confused

[Nick Phillips]

The settings relating to display of site title & course name are confusing and do not do what it appears they are intended to do.

1) sitetitle claims to control whether or not sitetitletext is displayed, but does not; it controls whether or not theme_adaptable_remove_site_fullname is called to modify $PAGE->heading instead;

2) hidecoursetitlemobile has no effect when hideheadermobile is set to hide. From reading descriptions of functionality, this is unexpected.

3) hidecoursetitlemobile description should mention that it also hides site logo if set to hide.

4) it would probably be better to allow separate control of hiding of site title/logo and course title for mobile.

[Jeremy Hopkins]

Hi, thanks for this.

1. Is a known issue we need to fix
2. Is also a known issue but I am not sure what to do about that. hideheadermobile removes the outer div, but if it is shown then we want control of what appears within it.
3. / 4 Will look at that too

[Nick Phillips]

Things have changed since this issue was filed. But, from #444:

Actually the logo / title / course combination works as expected. If you want other combination, you can use the custom title that provided many more options like add logo and title together.

So, if you want another kind of combinations, open a new proposal and will think on it. Keep in mind that you are always free to modify the code and create your own theme.

This issue is officially closed as solved because now works as expected.

So this issue still applies - clearly many users expect to be able to use a logo and either a course title (as they have been doing so thus far) or a site title (but have been disappointed).

Fernando suggests that custom title options are adequate for these cases; they are not - most obviously there is no way to use that to get course title into the header.

I suggest that there are several common existing use cases:

1. Logo only throughout site
2. Logo only at site level, logo + course title where possible
3. Site and course titles in use with no logo

based on how the older versions of the theme worked. Custom title will also be in use, but probably not much as it is relatively new and does not allow for course titles to be displayed.

The most flexible and least confusing way to handle this would appear to be to have something along the lines of:

• a 100% width titlecontainer div (must be full width to allow for title width setting to be based on sensible parent width)
• within that div, up to 3 more divs - logocontainer, sitetitlecontainer & coursetitlecontainer, each of which can be explicitly independently enabled or disabled, and with control over vertical alignment.

Logo display should be controlled by a setting with options "always", "at site level only", "within courses only" and "never" or similar. Site title display should be controlled by another setting with similar options. Course title display should be as at present - fullname, shortname or off.

Each of logo, site and course titles needs at least the option to be hidden on mobile (it's conceivable that you'd want to have one or other on on mobile but not on desktop, but that can wait). Current font controls are pretty good. Each div will probably need an option to control padding-top or similar, to enable vertical alignment of text with whatever part of the logo is appropriate.

As I've said before, I'm happy to work on this if I know what to aim at.

[Richard Schwarz]

Yep - Agree with nwp. Old versions of Adaptable had the feature of logo + Course name, or logo + site title on all pages. One of the many reasons for choosing the theme. Installers have come to expect that as a feature of theme, so to say that it was never intended as a feature doesn't matter - it was, and is. Please fix.

[Nick Phillips]

If anyone desperately needs old behaviour, see https://bitbucket.org/nwp90/moodle-theme_adaptable/branch/nwp90-fix-headings-2

Not submitting PR at this point as it doesn't yet allow enough flexibility.

[Info 3bits]

Fixed in #490