Undefined property in block layout, marketing layout, slider options, and footer layout

[Hartmut Scherer]

I tested Adaptable version 2016012502 in our life site by using "Allow theme changes by using URL," when I got a message (see attachment) with undefined property for block layouts, marketing layouts, slider options and footer layout.

[Jeremy Hopkins]

Thanks Hartmut,

That will help. I have seen this before, it shoudl go away once you set the theme up properly. Its caused by the admin settings using a loop and potentially not finding what it needs to, I need to do some more work on that.

[Jeremy Hopkins]

Fix #296 - if not already set define looped settings with a default value.

→ <<cset 45129c224bf9>>

[Jeremy Hopkins]

Hi Hartmut,

Can you please test the latest version:

https://bitbucket.org/covuni/moodle-theme_adaptable/get/master.zip

and let me know if this resolves the issue?

Thanks

[Jeremy Hopkins]

Waiting results of testing before closing.

[Hartmut Scherer]

Hi Jeremy,

Thanks for the updated version of Adaptable. I could only briefly test the new version of Adaptable as I will be teaching in a few minutes. I will be back after 90 minutes. After the installation I went straight to my dashboard and got this error message: Notice: Undefined property: stdClass::$slideroption2 in /home/pibceduc/public_html/theme/adaptable/settings/frontpage_slider.php on line 71

Notice: Undefined property: stdClass::$slideroption2 in /home/pibceduc/public_html/theme/adaptable/settings/frontpage_slider.php on line 105

Notice: Undefined property: stdClass::$slideroption2 in /home/pibceduc/public_html/theme/adaptable/settings/frontpage_slider.php on line 71

Notice: Undefined property: stdClass::$slideroption2 in /home/pibceduc/public_html/theme/adaptable/settings/frontpage_slider.php on line 105

With kind regards, Hartmut

[Jeremy Hopkins]

Thanks Hartmut,

I will look at that too, there is another change I can make which should resolve this. I will let you know when that is done.

[Hartmut Scherer]

Hi Jeremy,

I did more testing. You really improved the theme a lot. Cron is running properly now. I only got one more debug message before I logged in.

Undefined property: stdClass::$market1 in /home/pibceduc/public_html/theme/adaptable/renderers.php on line 650

The same undefined property is also reported for market 2 - 11. The theme itself is very good and I like what you have been doing.

With kind regards, Hartmut

[Stephan Göldi]

Hi Jeremy,

Really nice theme, thank you for this and your effort to fix this bug. I've the same as Hartmut here on a test server.

Best regards Stephan

[Jeremy Hopkins]

Fix #296 - trap additional errors where looped settings are not populated.

→ <<cset 194df2e71270>>

[Jeremy Hopkins]

Hi Hartmut, Stephan,

Could you download the latest version and see whether this resolves the issue:

https://bitbucket.org/covuni/moodle-theme_adaptable/get/master.zip

I have not incremented the version on that, it will not prompt you to upgrade. It shouldnt cause a problem as I have not changed anything that would be cached, but if you experience problems purge your caches.

[Jeremy Hopkins]

Closed with GIT commit, re-opening for testing

[Stephan Göldi]

Hi Jeremy,

It's fine in my Moodle. I completly uninstall the theme and reinstall it from your master.zip. I get a lot of notifications when I turn on developers debug messages.

Of course I purged the cache as well.

Moodle-Version: 3.0.2+ (Build: 20160121)

[Hartmut Scherer]

Hi Jeremy,

I downloaded and installed the latest version of Adaptable and didn't see any debug messages so far. Thanks a lot for the fix.

With kind regards Hartmut

[Jeremy Hopkins]

Resolved with commit listed above, user reported they no longer saw error.