wrong ul in flexslider

Issue #317 resolved
Info 3bits created an issue

Found a bug in flexslider:

<ul class="slides"><li>
                    <a href="#"><img src="img_1900x600.jpg" alt="p1"/>
<li>

li tag is not close after each slide

Comments (7)

  1. Jeremy Hopkins
    • changed status to open

    Hi Fernando,

    I just had to reverse part of this change as it broke the display of text in the slider. We will need to re-visit whatever the original issue was.

  2. Jeremy Hopkins
    • changed status to open

    Hi Fernando,

    Looking at the current slider code if an image is present we always add a link from it, either to "#" or the url if one is set.

    Would it be better if we did not link the image to anything if no url was set?

    One issue we have here is that we are nesting one href inside anohther if buttons are used in the slider.

  3. Info 3bits reporter

    The commit solve the syntax error with or without slide caption, but I need to test with other elements.

    Probably the issue with the links is due to href="#"

  4. Log in to comment