- changed status to resolved
wrong ul in flexslider
Found a bug in flexslider:
<ul class="slides"><li>
<a href="#"><img src="img_1900x600.jpg" alt="p1"/>
<li>
li tag is not close after each slide
Comments (7)
-
reporter -
Revert part of Fix
#317as it broke display of text in slider→ <<cset c549f69f67b5>>
-
- changed status to open
Hi Fernando,
I just had to reverse part of this change as it broke the display of text in the slider. We will need to re-visit whatever the original issue was.
-
reporter - changed status to resolved
Fix
#317→ <<cset 13378b247b2b>>
-
- changed status to open
Hi Fernando,
Looking at the current slider code if an image is present we always add a link from it, either to "#" or the url if one is set.
Would it be better if we did not link the image to anything if no url was set?
One issue we have here is that we are nesting one href inside anohther if buttons are used in the slider.
-
reporter The commit solve the syntax error with or without slide caption, but I need to test with other elements.
Probably the issue with the links is due to href="#"
-
- changed status to resolved
#328created to look at conditional statements - Log in to comment
Fix
#317→ <<cset 80e8fdea43b6>>