1. covuni Avatar covuni
  2. Adaptable
  3. moodle-theme_adaptable
  4. Issues

Fix bugs and Improve header settings

Issue #376 resolved
Info 3bits created an issue

Site title is displayed twice even set to hide.

See: https://bitbucket.org/covuni/moodle-theme_adaptable/src/143da76f665feea842e4249bec8fe03305196c45/layout/includes/header.php?at=master&fileviewer=file-view-default#header.php-398

  • Fix duplicate title display described above
  • Move code to renderer
  • Split font settings for site title and course title
  • Add padding settings for site and course titles
  • Move setting for using search or social icons into header settings
  • Add padding option for search box in header settings
  • Move course title max width to header settings
  • Add setting for title height (main area containing logo and titles)
  • Update language strings with references to other relevant settings pages
  • Adjust default values for install
  • Remove older settings no longer required (check box for enabling social icons and old padding setting for site title)
  • Clean up array definitions using loops instead of hard coded arrays

Comments (8)

  4. Jeremy Hopkins

    I have made quite a few changes as part of this issue. I have tested it and it looks ok. One thing to watch out for is the chages I made to the array definitions, if there are errors in this some settings will not display. I have been through these and checked for problems as I went along but will go back and double check they are all working ok.

    On a side note I had thought we would be better off with a couple of functions to build arrays for settings making it easier to alter the number of values in a list from the actual setting as a parameter.

  9. Log in to comment
Assignee
Type
bug
Priority
major
Status
resolved
Votes
0
Watchers
2
Jira: the preferred issue tracker for Bitbucket. Join the team!