-
assigned issue to
- marked as task
- marked as minor
Inheriting from Adaptable: Hardcoded settings
Issue #493
resolved
Good day,
we had some problems inheriting from the Adaptable theme. The renderer frequently doesn't take the currently loaded theme into account. For example adaptable renderers.php line 869:
get_config('theme_adaptable', 'breadcrumbseparator')
Some settings like the frontpage slider however dynamically get their settings from the current theme adaptable renderers.php line 753:
$noslides = $PAGE->theme->settings->slidercount;
We would really like to avoid overwriting your theme in the child theme as much as possible. It would be nice, if the selection for the source of the settings would be consistent (either all from the adaptable theme, or all from the current theme).
Best regards Malte Eckhoff
Comments (2)
-
-
- changed status to resolved
fix
#493→ <<cset b5247215a054>>
- Log in to comment
Thanks for your request.
We will try to rewrite the code to remove the function.
I hope could be released in the next version 1.2.4