Incorrect styling of block "tree" items

[Jeremy Hopkins]

The menu tree in admin and navigation blocks does not style properly because of code starting on line 114 of blocks.css

/* Navigation block */
.jsenabled .block_settings .block_tree .tree_item.branch,
.block_navigation .block_tree .tree_item.branch {
    color: [[setting:linkcolor]] !important;
}

I believe this should be using [[setting:blocklinkcolor]] NOT setting:linkcolor

Or perhaps it should have its own setting if it is not [[setting:blocklinkcolor]]

Currently those menu tree items retain the default sitewide link color as opposed to the block settings

[Info 3bits]

Should be blocklinkcolor that is usually the same that linkcolor to get a coherent design.

[Manoj Solanki]

Fix #828.

→ <<cset 25d7f10ce2bb>>

[Manoj Solanki]

The cause of this was the a: selector using "!important". We should work to remove this "!important" declaration in the css in the future IF we do not wish the setting "linkcolor" to generically to be applied to a: links.

Also, with this update, it might change the block link colours on existing sites now to whatever is set for "blocklinkcolor". It might be useful to say something about this in the next release?

[Info 3bits]

The colors are not consistent and are displayed using several variables.

[Info 3bits]

fix #828 match block link colour with links

→ <<cset 20dd79a52a37>>

[Info 3bits]

Added linkcolor as variable for blocks Removed the link color as a block setting