J001694 - wrong statics
J001694 Is listed as a u210 LS static when it in fact has a NS k346, in addition to its h296. Thanks!
Comments (11)
-
-
reporter - changed status to invalid
Something went wrong with this ticket - if still an issue please create a new issue and lets get it fixed
-
Yeah, The PR got screwed up. I'm still learning about git and created the PR but I kept working on that branch and other changes got added to the PR which I didn't know would happen. It is still an issue and a super easy fix. I'll see if I can get it fixed this afternoon.
-
reporter Make sure to modify the statics.json file in the tools folder - that is used to compile the compile.json file. I can then be sure it is accurate when using newer EVE data dumps.
-
I see. Should I additionally remove compile.json from source and add a note to the readme that json_builder.php must be run?
-
reporter As long as your branch is up-to-date with dev you can modify compile.json. I am hoping in the future to incorporate json_builder.php into a Laravel framework.
-
So, for now just modify both and just ignore json_builder.php?
-
reporter Yup - that is fine
-
PR #89 submitted to fix this issue.
-
reporter - changed status to resolved
Fix issue
#84j001694-wrong-staticshttps://bitbucket.org/daimian/tripwire/issues/84/j001694-wrong-statics
J001694 Is listed as a u210 LS static when it in fact has a NS k346, in addition to its h296.
- Update combine.json and statics.json to correct statics
→ <<cset 3d926645d318>>
-
reporter Merged in KrandasBrackentech/tripwire/feature/J001694_wrong_statics (pull request #89)
Fix issue
#84j001694-wrong-statics→ <<cset bb277c33c4bf>>
- Log in to comment
Fixed in PR #85