Missing string in dialogbox_confirmation
##close_this_window## do not exist in Google Drive document. And ##show_this_message_again## in the same popup.
Comments (11)
-
-
"show_this_message_again" has from the meaning an other key in the sheet: "show_this_msg" - should probaly unified by @dalerank
-
-
assigned issue to
What do you think - should be use the same loca_key for the same meaning or do you think we should implement redudant keys
-
assigned issue to
-
repo owner yes, you are right. @lars_gusowski could you please remove "show_this_msg"?
-
need to check if it is used somewhere else - and i think it was used somewhere else ;)
-
"show_this_msg" is used in lobby.js https://bitbucket.org/dalerank/caesaria/src/cf800a11eacb0c33daea890feb2740d8cd7a9240/bin/resources/system/lobby.js?at=master&fileviewer=file-view-default#lobby.js-34
therefore it couldn't be removed @dalerank
-
repo owner Could we unified this?
-
i checked the secound key to: "close_this_window" is used in https://bitbucket.org/dalerank/caesaria/src/cf800a11eacb0c33daea890feb2740d8cd7a9240/bin/resources/gui/dialogbox_confirmation.gui?at=master&fileviewer=file-view-default#dialogbox_confirmation.gui-6
"infobox_tooltip_exit" is used in https://bitbucket.org/dalerank/caesaria/src/cf800a11eacb0c33daea890feb2740d8cd7a9240/bin/resources/gui/infobox.gui?at=master&fileviewer=file-view-default#infobox.gui-39 https://bitbucket.org/dalerank/caesaria/src/cf800a11eacb0c33daea890feb2740d8cd7a9240/bin/resources/gui/popupmessage.gui?at=master&fileviewer=file-view-default#popupmessage.gui-37
therefore we should change the first one
-
-
assigned issue to
I'll prepere a fix :)
-
assigned issue to
-
- changed title to Missing string in dialogbox_confirmation
-
- changed status to resolved
fixed
#1288switched loca_key in dialogbox to existing loca_keys with same meaning→ <<cset c03b84f1bf77>>
- Log in to comment
"close_this_window" has from the meaning an other key in the sheet: "infobox_tooltip_exit" - should probaly unified by @dalerank