cppcheck issues

I let cppcheck run against the current master and it found 351 possible issues, some of them critical (memory leaks or potential crashers, like uninitialzed variables).

[core\smartptr.hpp:55]: (style) C-style pointer casting [core\smartptr.hpp:79]: (style) C-style pointer casting [main.cpp:73]: (style) Exception should be caught by reference.

[core\thread.cpp:69]: (style) C-style pointer casting [core\thread.cpp:160]: (style) C-style pointer casting [core\thread.cpp:161]: (style) C-style pointer casting [core\thread.cpp:162]: (style) C-style pointer casting

[events\event.hpp:99]: (style) The class 'ChangeSpeed' does not have a constructor. [events\playsound.hpp:24]: (style) The class 'PlaySound' does not have a constructor. [events\disaster.hpp:24]: (style) The class 'DisasterEvent' does not have a constructor. [events\dispatcher.cpp:60]: (performance) Prefer prefix ++/-- operators for non-primitive types. [events\dispatcher.cpp:79]: (performance) Prefer prefix ++/-- operators for non-primitive types. [events\fireworkers.hpp:24]: (style) The class 'FireWorkers' does not have a constructor. [events\fundissue.hpp:24]: (style) The class 'FundIssueEvent' does not have a constructor. [events\returnworkers.hpp:24]: (style) The class 'ReturnWorkers' does not have a constructor. [events\showadvisorwindow.hpp:24]: (style) The class 'ShowAdvisorWindow' does not have a constructor. [events\showempiremapwindow.hpp:24]: (style) The class 'ShowEmpireMapWindow' does not have a constructor. [events\showrequestwindow.hpp:25]: (style) The class 'ShowRequestInfo' does not have a constructor. [events\showtileinfo.hpp:24]: (style) The class 'ShowTileInfo' does not have a constructor. [events\winmission.cpp:43]: (style) Variable 'nextMission' is assigned a value that is never used. [game\ambientsound.cpp:150]: (performance) Prefer prefix ++/-- operators for non-primitive types. [game\citizen_group.cpp:21]: (performance) Prefer prefix ++/-- operators for non-primitive types. [game\citizen_group.cpp:102]: (performance) Prefer prefix ++/-- operators for non-primitive types. [game\citizen_group.cpp:118]: (performance) Prefer prefix ++/-- operators for non-primitive types. [game\infoboxmanager.cpp:88]: (performance) Variable 'title' is assigned in constructor body. Consider performing initialization in initialization list. [game\infoboxmanager.cpp:89]: (performance) Variable 'text' is assigned in constructor body. Consider performing initialization in initialization list. [game\infoboxmanager.cpp:122]: (performance) Variable 'title' is assigned in constructor body. Consider performing initialization in initialization list. [game\infoboxmanager.cpp:123]: (performance) Variable 'text' is assigned in constructor body. Consider performing initialization in initialization list. [game\infoboxmanager.cpp:282]: (warning) Conversion of string literal "already have constructor for this type" to bool always evaluates to true. [game\loader_map.cpp:107]: (warning) String literal ".map" doesn't match length argument for substr(). [game\loader_mission.cpp:64]: (performance) Prefer prefix ++/-- operators for non-primitive types. [game\loader_sav.cpp:317]: (error) Memory leak: pEdgeGrid [game\loader_sav.cpp:317]: (error) Memory leak: pRndmTerGrid [game\loader_sav.cpp:317]: (error) Memory leak: pRandomGrid [game\loader_sav.cpp:317]: (error) Memory leak: pZeroGrid [game\loader_sav.cpp:321]: (warning) String literal ".sav" doesn't match length argument for substr(). [game\pkwareinputstream.cpp:56]: (style) 'class PKDictionary' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory. [game\pkwareinputstream.cpp:189]: (style) Exception should be caught by reference. [game\pkwareinputstream.cpp:237]: (style) Exception should be caught by reference. [gfx\IMG_savepng.cpp:190]: (style) The scope of the variable 'alphas' can be reduced. [gfx\animation.cpp:115]: (warning) Redundant assignment of '_lastTimeUpdate' to itself. [gfx\layerbuild.hpp:46] -> [gfx\layer.hpp:81]: (warning) The class 'LayerBuild' defines member variable with name '_d' also defined in its parent class 'Layer'. [gfx\city_renderer.cpp:188]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gfx\layer.cpp:350]: (style) The scope of the variable 'pic' can be reduced. [gfx\layer.cpp:195]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gfx\layer.cpp:353]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gfx\tilesarray.hpp:29]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gfx\layerbuild.cpp:158]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gfx\layercrime.cpp:45]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layerdamage.cpp:50]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layerdestroy.cpp:258]: (performance) Variable '_clearPic' is assigned in constructor body. Consider performing initialization in initialization list. [gfx\layereducation.cpp:73]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layereducation.cpp:171]: (style) The scope of the variable 'lvlValue' can be reduced. [gfx\layerentertainment.cpp:64]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layerfire.cpp:47]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layerfood.cpp:49]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layerhealth.cpp:58]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layerreligion.cpp:49]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layertax.cpp:45]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\layertroubles.cpp:41]: (style) The scope of the variable 'needDrawAnimations' can be reduced. [gfx\sdl_engine.cpp:97] -> [gfx\sdl_engine.cpp:105]: (performance) Variable 'systemBpp' is reassigned a value before the old one has been used. [gfx\tile.cpp:67]: (warning) Conversion of string literal "error: picture is null" to bool always evaluates to true. [gfx\tilemap.cpp:255]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodhelper.cpp:74]: (performance) Function parameter 'prName' should be passed by reference. [good\goodstore.cpp:324] -> [good\goodstore.cpp:320]: (warning) Missing bounds check for extra iterator increment in loop. [good\goodstore.cpp:251]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodstore.cpp:276]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodstore.cpp:304]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodstore.cpp:320]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodstore.cpp:323]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodstore.cpp:324]: (performance) Prefer prefix ++/-- operators for non-primitive types. [good\goodstore_simple.cpp:172]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\advisor_chief_window.hpp:36] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorChiefWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\widget.hpp:60]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\widget.hpp:81]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\widget.hpp:484]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\advisor_education_window.cpp:59]: (performance) Variable '_info' is assigned in constructor body. Consider performing initialization in initialization list. [gui\advisor_education_window.hpp:36] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorEducationWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\pushbutton.hpp:118] -> [gui\widget.hpp:458]: (warning) The class 'PushButton' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\label.hpp:123] -> [gui\widget.hpp:458]: (warning) The class 'Label' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_emperor_window.hpp:49] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorEmperorWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\groupbox.hpp:60] -> [gui\widget.hpp:458]: (warning) The class 'GroupBox' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\listbox.hpp:173] -> [gui\widget.hpp:458]: (warning) The class 'ListBox' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\dialogbox.hpp:44] -> [gui\widget.hpp:458]: (warning) The class 'DialogBox' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_employers_window.cpp:48]: (performance) Variable '_title' is assigned in constructor body. Consider performing initialization in initialization list. [gui\advisor_employers_window.hpp:35] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorEmployerWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_entertainment_window.cpp:62]: (performance) Variable '_info' is assigned in constructor body. Consider performing initialization in initialization list. [gui\advisor_entertainment_window.hpp:37] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorEntertainmentWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\festival_planing_window.hpp:44] -> [gui\widget.hpp:458]: (warning) The class 'FestivalPlaningWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_finance_window.hpp:36] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorFinanceWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_health_window.hpp:36] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorHealthWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_legion_window.hpp:33] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorLegionWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_ratings_window.hpp:35] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorRatingsWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_religion_window.cpp:43]: (warning) Member variable 'ReligionInfoLabel::_lastFestival' is not initialized in the constructor. [gui\advisor_religion_window.hpp:36] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorReligionWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisor_trade_window.cpp:47]: (warning) Member variable 'TradeGoodInfo::_stacking' is not initialized in the constructor. [gui\advisor_trade_window.cpp:213]: (warning) Member variable 'TradeStateButton::goodsQty' is not initialized in the constructor. [gui\advisor_trade_window.hpp:39] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorTradeWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\advisors_window.hpp:41] -> [gui\widget.hpp:458]: (warning) The class 'AdvisorsWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\image.hpp:60] -> [gui\widget.hpp:458]: (warning) The class 'Image' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\environment.hpp:66] -> [gui\widget.hpp:458]: (warning) The class 'GuiEnv' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\console_utils.hpp:15]: (style) 'ConsoleError::operator=' should return 'ConsoleError &'. [gui\console_utils.hpp:10]: (performance) Function parameter 'str' should be passed by reference. [gui\console_utils.hpp:20]: (performance) Function parameter 'str' should be passed by reference. [gui\console_utils.hpp:39]: (style) Unused private function: 'ConsoleParser::isNameDone' [gui\console_dispatcher.cpp:101]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\console_dispatcher.cpp:114]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\console_utils.cpp:3]: (performance) Function parameter 'str' should be passed by reference. [gui\console_utils.cpp:19]: (performance) Function parameter 'str' should be passed by reference. [gui\contextmenu.cpp:278]: (style) The scope of the variable 't' can be reduced. [gui\contextmenu.hpp:145] -> [gui\widget.hpp:458]: (warning) The class 'ContextMenu' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\dictionary.hpp:40] -> [gui\widget.hpp:458]: (warning) The class 'DictionaryWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\editbox.cpp:68]: (warning) Redundant assignment of 'border' to itself. [gui\editbox.cpp:1243]: (style) The scope of the variable 'c' can be reduced. [gui\editbox.cpp:62]: (warning) Member variable 'Impl::oldCursorPos' is not initialized in the constructor. [gui\editbox.hpp:172] -> [gui\widget.hpp:458]: (warning) The class 'EditBox' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\empiremap_window.hpp:40] -> [gui\widget.hpp:458]: (warning) The class 'EmpireMapWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\environment.cpp:127]: (warning) Conversion of string literal "Called OnPreRender() function needed" to bool always evaluates to true. [gui\film_widget.hpp:46] -> [gui\widget.hpp:458]: (warning) The class 'FilmWidget' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\info_box.hpp:66] -> [gui\widget.hpp:458]: (warning) The class 'InfoboxSimple' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\infobox_legion.hpp:35] -> [gui\info_box.hpp:66]: (warning) The class 'InfoboxLegion' defines member variable with name '_d' also defined in its parent class 'InfoboxSimple'. [gui\special_orders_window.hpp:44] -> [gui\widget.hpp:458]: (warning) The class 'BaseSpecialOrdersWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\infobox_market.cpp:96]: (style) Variable 'goodName' is assigned a value that is never used. [gui\label.cpp:66]: (warning) Member variable 'Impl::isBorderVisible' is not initialized in the constructor. [gui\label.cpp:66]: (warning) Member variable 'Impl::backgroundMode' is not initialized in the constructor. [gui\label.cpp:299]: (warning) Conversion of string literal "Font must be exists" to bool always evaluates to true. [gui\scrollbar.hpp:135] -> [gui\widget.hpp:458]: (warning) The class 'ScrollBar' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\listbox.cpp:843]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\loadmapwindow.hpp:53] -> [gui\widget.hpp:458]: (warning) The class 'LoadMapWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\menu.hpp:48] -> [gui\widget.hpp:458]: (warning) The class 'Menu' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\overlays_menu.hpp:47] -> [gui\widget.hpp:458]: (warning) The class 'OverlaysMenu' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\message_stack_widget.hpp:44] -> [gui\widget.hpp:458]: (warning) The class 'WindowMessageStack' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\minimap_window.hpp:47] -> [gui\widget.hpp:458]: (warning) The class 'Minimap' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\mission_target_window.hpp:39] -> [gui\widget.hpp:458]: (warning) The class 'MissionTargetsWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\modal_widget.cpp:44]: (style) C-style pointer casting [gui\overlays_menu.cpp:169]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\playername_window.hpp:42] -> [gui\widget.hpp:458]: (warning) The class 'WindowPlayerName' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\popup_messagebox.hpp:42] -> [gui\widget.hpp:458]: (warning) The class 'PopupMessageBox' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\pushbutton.cpp:78]: (warning) Member variable 'Impl::bgStyle' is not initialized in the constructor. [gui\requestwindow.hpp:44] -> [gui\widget.hpp:458]: (warning) The class 'EmperrorRequestWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\rightpanel.hpp:37] -> [gui\widget.hpp:458]: (warning) The class 'MenuRigthPanel' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\save_dialog.hpp:41] -> [gui\widget.hpp:458]: (warning) The class 'SaveDialog' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\senate_popup_info.hpp:37] -> [gui\widget.hpp:458]: (warning) The class 'SenatePopupInfo' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\sound_options_window.hpp:47] -> [gui\widget.hpp:458]: (warning) The class 'SoundOptionsWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\video_options_window.hpp:48] -> [gui\widget.hpp:458]: (warning) The class 'VideoOptionsWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\widget.cpp:297]: (style) The scope of the variable 'closest' can be reduced. [gui\widget.cpp:32]: (warning) Conversion of string literal "Parent must be exists" to bool always evaluates to true. [gui\widget.cpp:730]: (warning) Conversion of string literal "parent must be exist for element" to bool always evaluates to true. [gui\widget.cpp:562]: (performance) Prefer prefix ++/-- operators for non-primitive types. [gui\widgetpositionanimator.cpp:40]: (warning) Conversion of string literal "parent must be exist" to bool always evaluates to true. [gui\win_mission_window.hpp:39] -> [gui\widget.hpp:458]: (warning) The class 'WinMissionWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [gui\window_gamespeed_options.hpp:45] -> [gui\widget.hpp:458]: (warning) The class 'GameSpeedOptionsWindow' defines member variable with name '_d' also defined in its parent class 'Widget'. [objects\amphitheater.hpp:48] -> [objects\entertainment.hpp:52]: (warning) The class 'Amphitheater' defines member variable with name '_d' also defined in its parent class 'EntertainmentBuilding'. [objects\aqueduct.cpp:133]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\building.hpp:70] -> [objects\construction.hpp:66]: (warning) The class 'Building' defines member variable with name '_d' also defined in its parent class 'Construction'. [objects\coastalbuilding.hpp:48] -> [objects\factory.hpp:79]: (warning) The class 'CoastalFactory' defines member variable with name '_d' also defined in its parent class 'Factory'. [objects\colosseum.hpp:45] -> [objects\entertainment.hpp:52]: (warning) The class 'Colosseum' defines member variable with name '_d' also defined in its parent class 'EntertainmentBuilding'. [objects\construction.cpp:68]: (style) The scope of the variable 'lvlTrouble' can be reduced. [objects\dock.cpp:188]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\dock.cpp:209]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\dock.cpp:335]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\dock.cpp:346]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\farm.hpp:40] -> [objects\factory.hpp:79]: (warning) The class 'Farm' defines member variable with name '_d' also defined in its parent class 'Factory'. [objects\fortification.cpp:362] -> [objects\fortification.cpp:363]: (warning) Variable 'index' is reassigned a value before the old one has been used. 'break;' missing? [objects\gatehouse.hpp:46] -> [objects\building.hpp:70]: (warning) The class 'Gatehouse' defines member variable with name '_d' also defined in its parent class 'Building'. [objects\fountain.cpp:38]: (warning) Member variable 'Fountain::_haveReservoirWater' is not initialized in the constructor. [objects\high_bridge.cpp:234]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\high_bridge.cpp:279]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\high_bridge.cpp:312]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\high_bridge.cpp:326]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\high_bridge.cpp:340]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\high_bridge.cpp:354]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\hippodrome.hpp:58] -> [objects\entertainment.hpp:52]: (warning) The class 'Hippodrome' defines member variable with name '_d' also defined in its parent class 'EntertainmentBuilding'. [objects\house.cpp:830] -> [objects\house.cpp:827]: (warning) Missing bounds check for extra iterator increment in loop. [objects\house.cpp:330]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\house.cpp:331]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\house.cpp:827]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\house.cpp:830]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:342]: (style) The scope of the variable 'signSum' can be reduced. [objects\low_bridge.cpp:34]: (warning) Member variable 'LowBridgeSubTile::_info' is not initialized in the constructor. [objects\low_bridge.cpp:34]: (warning) Member variable 'LowBridgeSubTile::_imgId' is not initialized in the constructor. [objects\low_bridge.cpp:194]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:233]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:246]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:269]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:283]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:297]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:311]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\low_bridge.cpp:410]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\metadata.cpp:180]: (performance) Variable '_prettyName' is assigned in constructor body. Consider performing initialization in initialization list. [objects\military.cpp:252]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\working.hpp:63] -> [objects\building.hpp:70]: (warning) The class 'WorkingBuilding' defines member variable with name '_d' also defined in its parent class 'Building'. [objects\watersupply.hpp:46] -> [objects\construction.hpp:66]: (warning) The class 'WaterSource' defines member variable with name '_d' also defined in its parent class 'Construction'. [objects\house.hpp:116] -> [objects\building.hpp:70]: (warning) The class 'House' defines member variable with name '_d' also defined in its parent class 'Building'. [objects\low_bridge.hpp:44] -> [objects\construction.hpp:66]: (warning) The class 'LowBridge' defines member variable with name '_d' also defined in its parent class 'Construction'. [objects\high_bridge.hpp:44] -> [objects\construction.hpp:66]: (warning) The class 'HighBridge' defines member variable with name '_d' also defined in its parent class 'Construction'. [objects\military.hpp:94] -> [objects\building.hpp:70]: (warning) The class 'FortArea' defines member variable with name '_d' also defined in its parent class 'Building'. [objects\tower.cpp:170]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\warehouse.cpp:192]: (performance) Prefer prefix ++/-- operators for non-primitive types. [objects\watersupply.cpp:69]: (warning) Member variable 'Reservoir::_isWaterSource' is not initialized in the constructor. [objects\working.cpp:107]: (performance) Prefer prefix ++/-- operators for non-primitive types. [pathway\path_finding.cpp:92]: (performance) Prefer prefix ++/-- operators for non-primitive types. [pathway\pathway.cpp:205]: (style) Statements following return, break, continue, goto or throw will never be executed. [pathway\pathway.cpp:291]: (warning) Conversion of string literal "Unexpected Direction:" to bool always evaluates to true. [pathway\pathway.cpp:188]: (error) Uninitialized variable: res [pathway\pathway.cpp:342]: (performance) Prefer prefix ++/-- operators for non-primitive types. [religion\divinities.cpp:88]: (warning) Member variable 'RomeDivinityBase::_relation' is not initialized in the constructor. [scene\briefing.cpp:94]: (warning) Member variable 'Briefing::Result' is not initialized in the constructor. [scene\level.cpp:394]: (style) The scope of the variable '_mouseEventTarget' can be reduced. [scene\level.cpp:180]: (style) Variable 'btnMenu' is assigned a value that is never used. [scene\level.cpp:445]: (performance) Prefer prefix ++/-- operators for non-primitive types. [scene\menu.cpp:220]: (warning) Member variable 'StartMenu::Result' is not initialized in the constructor. [sound\engine.cpp:283]: (performance) Prefer prefix ++/-- operators for non-primitive types. [vfs\archive_sg2.cpp:290]: (style) The scope of the variable 'x_offset' can be reduced. [vfs\archive_sg2.cpp:259]: (style) Checking if unsigned variable 'data_length' is less than zero. [vfs\archive_sg2.cpp:109]: (performance) Variable '_file' is assigned in constructor body. Consider performing initialization in initialization list. [vfs\archive_zip.cpp:414]: (warning) Assignment of function parameter has no effect outside the function. [vfs\archive_zip.cpp:415]: (warning) Assignment of function parameter has no effect outside the function. [vfs\archive_zip.cpp:627] -> [vfs\archive_zip.cpp:628]: (performance) Variable 'err' is reassigned a value before the old one has been used. [vfs\archive_zip.cpp:414]: (warning) Redundant assignment of 'p' to itself. [vfs\archive_zip.cpp:415]: (warning) Redundant assignment of 'p' to itself. [vfs\archive_zip.cpp:668]: (style) Variable 'uncompressedSize' is assigned a value that is never used. [vfs\directory.cpp:80]: (performance) Prefer prefix ++/-- operators for non-primitive types. [vfs\directory.cpp:324] -> [vfs\directory.cpp:326]: (performance) Variable 'emode' is reassigned a value before the old one has been used. [vfs\entries.cpp:79]: (performance) Prefer prefix ++/-- operators for non-primitive types. [vfs\entries.cpp:217]: (performance) Prefer prefix ++/-- operators for non-primitive types. [vfs\entries.cpp:247]: (performance) Prefer prefix ++/-- operators for non-primitive types. [vfs\filenative_impl.cpp:46]: (warning) Member variable 'FileNative::_size' is not initialized in the constructor. [vfs\filenative_impl.cpp:46]: (warning) Member variable 'FileNative::_mode' is not initialized in the constructor. [vfs\filesystem.cpp:646]: (style) Unused variable: e2 [vfs\filesystem.cpp:647]: (style) Unused variable: e3 [walker\cart_pusher.cpp:267]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\cart_pusher.cpp:275]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\enemysoldier.cpp:129]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\immigrant.cpp:63]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\market_lady.cpp:119]: (performance) Possible inefficient checking for 'priorityGoods' emptiness. [walker\merchant.cpp:106]: (performance) Possible inefficient checking for 'warehouseRating' emptiness. [walker\merchant.cpp:102]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\merchant.cpp:122]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\patrician.cpp:39]: (style) Clarify calculation precedence for '%' and '?'. [walker\protestor.cpp:117] -> [walker\protestor.cpp:118]: (performance) Variable 'constructions' is reassigned a value before the old one has been used. [walker\protestor.cpp:95]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\protestor.cpp:126]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\protestor.cpp:178]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\seamerchant.cpp:104]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\seamerchant.cpp:315]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\seamerchant.cpp:339]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\seamerchant.cpp:340]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\serviceman.cpp:353]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary. [walker\serviceman.cpp:374]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary. [walker\walker.cpp:681]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary. [walker\servicewalker_helper.hpp:28]: (performance) Prefer prefix ++/-- operators for non-primitive types. [walker\servicewalker_helper.hpp:41]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\computer_city.cpp:142]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\computer_city.cpp:150]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\computer_city.cpp:157]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\computer_city.cpp:164]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\traderoute.cpp:83]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\traderoute.cpp:195]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\traderoute.cpp:201]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\traderoute.cpp:207]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\trading.cpp:48]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\trading.cpp:64]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\trading.cpp:76]: (performance) Prefer prefix ++/-- operators for non-primitive types. [world\trading.cpp:155]: (performance) Prefer prefix ++/-- operators for non-primitive types.

Comments (6)