1. Roman Telezhynskyi Avatar Roman Telezhynskyi
  2. Untitled project
  3. Valentina
  4. Issues

New measurements structure

Issue #314 closed
Matthias Burkhardt created an issue

At the moment, there are much much measurements in Valentina, in different languages, where many of them are meant the same measurement (i.e. "waist_girth"="Taillenweite" etc.). This is confusing as the list is very long an the user has no search function.

Proposal:
The measurements are structured, only one measurement for "waist_girth" is shown to the user, this measurement has an internal name to the program, and that internal name is translated by the UI into the UI language.

Example: Internal (english) name is "waist_girth".
If the UI ist set German, this measurement is named "Taillenweite" by the UI.
If the UI is set english, this measurement is shown "waist girth" by the UI.

Additional proposal:
The Shortcut for the different pattern construction Systems is also shown in Brackets.
Therefore, a picklist for the pattern construction systems has to be implemented.

Example: Internal (english) name is "waist_girth".
If the UI ist set German, and System HAKA/Müller & Sohn is picked, this measurement is named "Taillenumfang (Tu)" by the UI.

If the UI is set english, and System HAKA/Müller & Sohn is picked, this measurement is shown "waist girth (Tu)" by the UI (if the english version of HAKA also uses this name).

If the UI ist set German, and System Systemschnitt/Jansen&Rüdiger is picked, this measurement is named "Taillenweite (Tw)" by the UI.

If the UI is set english, and System Systemschnitt/Jansen&Rüdiger is picked, this measurement is shown "waist girth (Tw)" by the UI.

This would ease the construction process and minimize errors by translating the measurement names.

The set of measurements should incorporate all basic measures used by the implemented pattern construction Systems.

All calculated measurements (with the formulars provided with the construction system) could also be provided by Valentina if the underlying measures are available.

Comments (42)

  6. Roman Telezhynskyi repo owner

    I think we could make several TS files for each system. And load it dynamically. It will even make localization much easier for translators.

  7. Matthias Burkhardt reporter

    Agreed. One file for every language / pattern construction system combination.

    Main task will be to define the measures that go into this file.

  8. Roman Telezhynskyi repo owner

    Main task will be to define the measures that go into this file.

    Not quite right. All known and supported measurements will go in a file. For selecting only specific measurements user will use templates.

  9. Matthias Burkhardt reporter

    That is exactly what I meant. The known and supported measures have to be defined. Or is this already done?

  11. Matthias Burkhardt reporter

    Hi Roman, the Figures are awesome! Lots of measures, is there any list with corresponding names? I am sitting here and trying to make a concordance list to the german names of the two pattern construction systems I have, Haka (Müller & Sohn) and Systemschnitt (Jansen & Rüdiger, the Books by Schiele & Schön). But this is no easy task as especially Systemschnitt has not very much measures. Hope I got that right that the black ones (i.e. A5a is the measure around, and the brown one (i.e. A5b) is only the front "width"?

  12. Roman Telezhynskyi repo owner

    Hi Roman, the Figures are awesome!

    It is Susan, not me.

    Lots of measures, is there any list with corresponding names?

    We should ask Susan. I have one, but i think Susan has updated since our last changes.

  13. Matthias Burkhardt reporter

    OK, Susan, the Figures are awesome! :-)

    I just try to find the corresponding ones, not sure if all will be right, but time will tell...

  16. Susan Spencer

    Not resolved yet! Issue #359 'Make Measurement Templates for patternmaking systems' is required to implement this feature. Issue #359 is not resolved yet, so this issue can't be set to resolved. Current discussion is at issue #359

  17. Roman Telezhynskyi repo owner

    Issue #359 'Make Measurement Templates for patternmaking systems' is required to implement this feature.

    Nope. Quite opposite. As is see for creation templates a user need mapping translation that should provide this issue.

    Not resolved yet!

    It is not resolved if only you are talking about translation.

  20. Susan Spencer

    Attached file to show how measurement bust_circumference is translated into Aldrich's Mens' system.

    In Valentina bust_circumference's Full Description is "Bust circumference"

    In Aldrich bust_circumference's Full Description is "Chest"

  21. Susan Spencer

    Added modified screenshot to illustrate what the final result of this issue will be. The 'Full Name' column in Tape/Measurements will contain the 'translated' phrases from the measurements_pxx.ts file from Transifex.

  23. Susan Spencer

    Yeah, I'm not sure it's working properly, can you check?

    I submitted changes to the Aldrich men file (measurements_p41.ts) in Transifex a month ago. Yet the Aldrich men's measurement names are not appearing in the Full Name column. This is why I posted the screenshots.

    Is there something I'm not doing correctly, or is there something that I don't understand, or is the file not in the build, or did I update the wrong file?

    I didn't want to submit an issue if the error is on my side.

  25. Susan Spencer

    Are we translating the Variable Name, eg bust_circ? I thought we were translating the Full Name, eg Bust Circumference because pattern systems' measurement names FREQUENTLY have spaces in them -- they are usually phrases of several words. If we can't have spaces then there is a problem.

  26. Roman Telezhynskyi repo owner

    Are we translating the Variable Name, eg bust_circ?

    Yes.

    We translate all: variable name, short name and full name. The full name can have spaces.

  27. Susan Spencer

    When this measurement is used in a pattern in the formula for a point or other object, eg Valentina uses bust_circ, pattern system uses Chest, and user creates point by dividing by 4:

    1. Does the f(x) dialog box display Chest/4 or bust_circ/4?
    2. Does the .val file store Chest/4, or does it store bust_circ/4?
  29. Susan Spencer

    All that needs to be translated is the Full Name. I know the initial description for this issue uses the Valentina name. I tried to discuss this at the time but didn't put my comments in the issue list.

    Users need to have the ability to associate the Valentina name with the pattern system name.

    If the pattern contains the valentina name then users have no way to trace the valentina name to the pattern system name. This disconnect is a problem.

    This brings up another question: Does the build process automatically pull in the latest version of translations?

  30. Susan Spencer

    okay that's good that the val file stores the Valentina internal name. That means the f(x) box displays the Valentina internal name. So the user needs to see the Valentina internal name in the left hand column, and see the pattern system name in the right hand column. They need this in order to update their formulas properly.

  31. Roman Telezhynskyi repo owner

    I think you did not understand. You can translate all names. And user will not see internal names at all. Why is it problem?

  32. Roman Telezhynskyi repo owner

    Users need to have the ability to associate the Valentina name with the pattern system name.

    You mean translators?

    If the pattern contains the valentina name then users have no way to trace the valentina name to the pattern system name. This disconnect is a problem.

    Translation file has all this data.

    This brings up another question: Does the build process automatically pull in the latest version of translations?

    Yes.

  33. Susan Spencer

    Measurements has typically been a very difficult area for discussions.

    I will copy the measurements_p41.ts file from Transifex into my repo of Valentina, build locally with Qt, and check the following test points.

    #Check translation and usability:

    1. In Tape app, Measurement dialog:
      1a. Valentina name in the left hand column
      1b. Pattern system name in the right hand column
    2. In Valentina app, Draw mode, tool f(x) dialog, Measurements radio button selected:
      2a. Valentina name in the left hand column
      2b. Pattern system name in the right hand column
    3. Valentina name in f(x) dialog box for point created with Valentina measurement/pattern system measurement
    4. Valentina name in the .val file formula for the point from step #3
    5. Save & Close

    #Test with different pattern system
    6. Reopen pattern file
    7. Change pattern system
    8. Check items 1 through 4
    9. Save & Close

    #Test with no pattern system
    10. Reopen pattern file
    11. Set pattern system to blank or None
    12. Check items 1 through 4
    13. Save & Close
    14. Reopen pattern file

  34. Susan Spencer

    I translated the phrase 'Bust Circumference' to 'Chest' in measurements_p41.ts and measurements_p41_en_US.ts. I ran clean, qmake, and build Valentina. In the Information tab of Tape/Measurements, the translation doesn't appear, it shows 'Bust Circumference'. Can you tell me what steps I should take? Which files should be translated, and how do I add a translation file into the project?

  35. Roman Telezhynskyi repo owner

    Seems like command "tx pull --mode=developer --skip" not enough for pulling all data. Return to old way "tx pull --mode=developer -f -s --skip". ref #314.

    → <<cset 2fee36eab1e5>>

  37. Susan Spencer

    I did an 'hg pull' and 'hg update', then recompiled. It isn't showing the translated string from measurements_p41.ts Error_Tape_PatternSystem_translation_not_showing_translated_strings2.png

  40. Susan Spencer
    • changed status to open

    So theoretically yes the commits have been made, but it is unverified that the issue is completed. Keep this issue open until it is proven that it works.

    The test pattern system translation file measurement_p41_en_US.ts has not yet been included in a build.
    Making changes locally to measurement_p41_en_US.ts and building with Qt has not been successful.

  43. Log in to comment
Assignee
–
Type
proposal
Priority
major
Status
closed
Component
–
Milestone
–
Version
–
Votes
0
Watchers
1
Jira Software: the preferred issue tracker for Bitbucket. Join the team!