Settings saved to different INI files in different folders
Issue #508
resolved
Currently, there are three INI files with the following structure under Windows:
- %AppData%\ValentinaTeam\valentina.ini
- %AppData%\ValentinaTeam\tape.ini
- %AppData%\ValentinaTeam.ini
It is not really consistent to put two of them inside the "ValentinaTeam" folder and the third one up one directory.
I think, for a more consistent structure, you should initialize the QSettings object in vcommonsettings.cpp something like this (I'd prefer the second example):
QSettings settings(this->format(), this->scope(), this->organizationName(), this->organizationName());
or
QSettings settings(this->format(), this->scope(), this->organizationName(), "common");
This would keep all of the three files inside the %AppData%\ValentinaTeam folder, what I think is a bit better.
Comments (6)
-
repo owner
-
reporter
I'll try. Develop branch?
-
repo owner
I'll try. Develop branch?
No. Better use feature, will make your job less painful if something bad happen.
Read https://wiki.valentinaproject.org/wiki/Hacking:Making_pull_requests
Say me if something unclear for you in the tutorial.
-
repo owner
- changed status to resolved
Merged in pandel/valentina-devel/feature (pull request
#123)Resolve issue
#508. Settings saved to INI files in different folders.→ <<cset 45e2af634867>>
-
repo owner
Resolve issue
#508. Settings saved to INI files in different folders.→ <<cset 4ed0cbca8068>>
-
repo owner
Merged in pandel/valentina-devel/feature (pull request
#123)Resolve issue
#508. Settings saved to INI files in different folders.→ <<cset 45e2af634867>>
- Log in to comment
Yes, why not. Can you make a pull request?