- changed title to Improve feature: Rename Standard table to Multisize table
- changed component to Tape app
- changed milestone to v0.6.0
Improve feature: Rename Standard table to Multisize table
Multisize table instead of Standard table everywhere.
Comments (10)
-
-
I will take care of this issue.
What we want:
In the tape application, we want to change the strings of the GUI which contain "standard" to "multisize".
Question
Do we want to refactor the code as well, or we just take care of the GUI?
-
reporter Enough only to fix the GUI. But you can try to refactor the code as well if you have time for this. I don't mind.
-
Refactor in this issue or issue
#428? -
reporter In this.
#428is not trivial issue. I even don't understand now what it is all about. -
-
I don't mind refactoring the code so that the variables / function names etc are changed from "standard" to "multisize".
Roman probably knows best, if it's worth it or not? Will it make it easier for the future refactoring?
I'll read in the forum like you adviced susan, to understand better what it's all about :-)
-
I have made a pull request, I did the changes for the GUI and the code refactoring as well.
I didn't know how to handle the change in /ifc/schema/pattern/ (with the measurementTypes values) so for the moment I didn't to anything there.
Looking forward to hear what you think about my code Refactoring Roman :-) It wasn't easy because the string "standard" is found in a lot of files.
-
reporter - changed status to resolved
Resolved issue
#654. Improve feature: Rename Standard table to Multisize table.→ <<cset eb9c73c2ccb2>>
-
reporter - removed milestone
Removing milestone: v0.6.0 (automated comment)
- Log in to comment