Default seam allowance setting

Issue #712 resolved
Jennifer Maillet created an issue

It would be nice to have a default seam allowance setting that allows you to save seam allowances at a certain measurement for people that use the same seam allowance all of the time but it is not what populates currently. for example: It defaults to .39 inches but for my purposes I usually use .25

Comments (16)

  1. Ronan Le Tiec

    I'd like to implement this issue.

    What we have

    • The default value for the seam allowance is always 1cm / 10mm / 0.393701 inches and can't be changed.

    What we want:

    • A central setting to set the default value of the seam allowance to the desired value.
    • When changing the setting, it will no change the seam allowances for the workpieces already created. It will only change the default value for new pieces.

    Questions

    • Should it be an application setting ?
    • Or a pattern specific setting?

    Approaches

    • in the case of an application setting:
      • In File > Preference > Pattern
      • 3 fields "seam allowance default value", one for each unit (cm, mm and inches)
    • in the case of a pattern setting:
      • In File >Pattern Properties > General Info or new Tab ?
      • one field "seam allowance default value", the pattern has already a unit defined.
    • I would initiate the values as follow:
      • cm = 1
      • mm = 10
      • inches = 0.375 (3/8 of an inch). Is that right? Or is the most common seam allowance in inches .39?

    I'll wait for some feedback before I start implementing something.

  2. Roman Telezhynskyi repo owner

    Questions

    • Should it be an application setting ?
    • Or a pattern specific setting?

    Good question. Should be both i think. A pattern should keep selected value or use global if not setted. But global value should be editable too. Thus, user will have two places to edit.

    3 fields "seam allowance default value", one for each unit (cm, mm and inches)

    Better to add two fields: value and units. And convert value according to pattern units latter.

    Plus we have option about units in global settings. We can use it to find default units for user. Also system takes basic information from locale to guess what are right units.

    inches = 0.375 (3/8 of an inch). Is that right? Or is the most common seam allowance in inches .39?

    Probably in case of inches better to propose own value instead of converted from 1 cm.

    These are my thoughts for now.

  3. Ronan Le Tiec

    Good question. Should be both i think. A pattern should keep selected value or use global if not setted. But global value should be editable too. Thus, user will have two places to edit.

    true, it offers the most flexibility to make the two editable

    Better to add two fields: value and units. And convert value according to pattern units latter.

    Plus we have option about units in global settings. We can use it to find default units for user. Also system takes basic information from locale to guess what are right units.

    If we consider the global default unit, maybe one field is enough then? Or do you think it's stil better to have one field for the value here and one drop down for the unit?

    A few other questions:

    Should the value field be able to open the formula dialog ?

    For the default value in the pattern properties, is the tab "general info" the right place to put the field?

    For the default inches value, can someone who is familiar with this unit tell us which default value is best? Maybe @tusuzu ?

  4. Roman Telezhynskyi repo owner

    If we consider the global default unit, maybe one field is enough then? Or do you think it's stil better to have one field for the value here and one drop down for the unit?

    One should be enough.

    Should the value field be able to open the formula dialog ?

    Global no (QSpinBox), pattern specific - yes. But show only measurements and increments.

    For the default value in the pattern properties, is the tab "general info" the right place to put the field?

    I think yes.

    For the default inches value, can someone who is familiar with this unit tell us which default value is best? Maybe Susan Spencer ?

    You can continue without it for now. It is very easy to fix when we will know.

  5. Susan Spencer

    Typical seam allowance widths In US:

    • Home sewing patterns: 5/8"
    • Bespoke hand tailored garments: 1" or more
    • Ready-to-wear garments (and industrial sewing patterns): 1/4 to 1/3"
    • High fashion Ready-to-wear: 1/2" to 5/8"
    • Knits: 1/4 to 1/3"
  6. Roman Telezhynskyi repo owner

    Request from the start. :) Please, could you choose one the most appropriate for us to make it default?

  7. Roman Telezhynskyi repo owner

    true, it offers the most flexibility to make the two editable

    Forget about this idea, i thought little bit and think that better left only global option. The origin idea came to me from CAD systems. For example in DXF format they save settings not only about drawing, but also about user settings. Currently our philosophy is different. User should customize settings to get look they want.

  8. Ronan Le Tiec

    @dismi_ I need your help.

    I want to use the function VDomDocument::StrToUnits() in the class VCommonSettings. But I get errors when including the vdomdocument.h, maybe because of circular references.

    I get several errors like the following:

    /valentina_rlt/build-Valentina-Desktop_Qt_5_7_0_GCC_64bit-Debug/src/libs/ifc/bin/libifc.a(vdomdocument.o):-1: Fehler: Nicht definierter Verweis auf `QAbstractMessageHandler::metaObject() const'
    

    The german part translates to "Error : undefined reference to".

    I tried using a forward declaration for the class VDomDocument but unsuccessfully.

    I've commited my changed to my bitbucket : https://bitbucket.org/ronanletiec/valentina/commits/536007356a10d786dc8c49162de5e8ae2518e6f9

    Maybe you have an idea on how to proceed?

  9. Roman Telezhynskyi repo owner

    Maybe you have an idea on how to proceed?

    Move VDomDocument::StrToUnits and VDomDocument::UnitsToStr to vmisc/def.(h/cpp).

  10. Ronan Le Tiec

    Ok, I've made the change you suggested and did a pull request. They were quite a few files where the calls "VDomDocument::UnitsToStr()" had to be changed in "UnitsToStr()".

  11. Log in to comment