Seam allowance tool - object selection and preview

Issue #830 resolved
Ronan Le Tiec created an issue

When selecting objects with the seam allowance tool, the preview (the red line) is sometimes not up to date for a while. The problem seem to occur mostly when selecting curves or curved paths.

Also it happens sometimes that when selecting a curve, it's not taking into account at all and instead I get a straight line (even though the curve is selected clockwise).

Theses problems also seem to occur a bit randomly, sometimes it works and sometimes it doesn't.

Attached are 2 small videos so that you can see what I'm talking about and also a simple val file to make the tests.

Comments (10)

  1. Roman Telezhynskyi repo owner

    This is not a bug. Your example is bad. The reason for this are loops. Take a close look to a path on each step and you will see places where Valentina cuts loops. This is the reason why a path disappears. Thing is the tool not only previews selected objects, but also shows you a main path. And in your case the main path will degrade. Complete selection and you'll see you path as you desire, if it is possible.

    But you are right in one thing. This may cause a confusion. Probably we should find a way to show selection separate from a path prediction.

    So, this is not a bug, this is a feature.

    Play with this code to see difference with and without loop checking.

    QVector<QPointF> VPiece::MainPathPoints(const VContainer *data) const
        QVector<QPointF> points = GetPath().PathPoints(data);
        points = CheckLoops(CorrectEquidistantPoints(points));//A path can contains loops
        return points;
  2. Ronan Le Tiec reporter

    Ok i'm going to have a look at it to try to understand what you mean with the loops.

    Also it happens sometimes that when selecting a curve, it's not taking into account at all and instead I get a straight line (even though the curve is selected clockwise).

    In both videos you see that I select every curve / curved paths. I can understand that the 'preview' isn't always ok because of the loop-thing, but if i select every curves, I expect them to all be in the final result. And they are not, you see in the video that some are replaced by a straight line. This problem is a bug for me, not a feature. Or do I see it wrong and it also has to do with the loop?

  3. Roman Telezhynskyi repo owner

    It seems like you just did not select a curve. You tried, but because Valentina doesn't show a response in some cases it is impossible to understand was selection registered or not. So, it is clear now that we need to improve this part. Even if it's still important to remember about clearing loops highlighting a curve is also very important to produce less confusion.

  4. Ronan Le Tiec reporter

    Yes that's true, less confusion would improve the usability.

    Because the curve gets thick when doing the mouser-hover, I thought it would be definitly recognised and selected when clicked. In other cases like when selecting an item wouthout a specific tool, the clik done on the thickened-mouse-hover curve always work. Do you have any idea why it's sometimes not selecting it in seam allowance tool?

  5. Ronan Le Tiec reporter

    I just tested what you did here and I like it, now it's clear if the curve has been selected or not. Nice! I also saw your blog post, normally google translate does quite a good job and I understand them well, but on this one google translated some weird stuff :-) maybe there is to much technical vocabulary. Anyway, thanks.

  6. Log in to comment