macOS Mojave dark mode difficult to use

[Former user]

Using valentina_0.7.0a-20190103140932_10.12%2B_64bit-OSX.dmg on macOS 10.14.2 (18C54) Mojave.

If one's interface in macOS Mojave is set to native dark mode, Valentina will show an incorrectly dark interface even if the internal setting is not enabled.

When the internal setting is enabled, two issues become apparent:

1) The point names are white initially only to become black after a mouse cursor passes over them and 2) The black lines are very hard to see.

Normally, one could disable the dark mode in Valentina and use the normal 'light' interface but that does not work on macOS Mojave.

Attached screenshots show the behaviour more closely.

Suggested fix:

1) When Valentina is in dark mode, set a colour palette that allows better visibility of 'black' lines. Turn black to white for both black lines and point names. Leave hand-picked colours as they are.

2) When OS is in dark mode but Valentina is not, allow a 'light' palette for Valentina and not pull it from the OS as that won't produce good user experience.

[Former user]

OS: Dark Valentina: Dark Before mouse-over on points (white point names)

[Former user]

OS: Dark Valentina: Dark After mouse-over on points (black point names)

[Former user]

OS: Dark Valentina: Light

Wrong colour scheme

[Former user]

Hard to see default colour lines in Valentina dark mode.

[Roman Telezhynskyi]

If one's interface in macOS Mojave is set to native dark mode, Valentina will show an incorrectly dark interface even if the internal setting is not enabled.

First of all Valentina's dark mode is not finished feature. It is in pre alpha state. There is no support for scene. Also you must understand that our option do not control look for native MacOS dark mode.

When OS is in dark mode but Valentina is not, allow a 'light' palette for Valentina and not pull it from the OS as that won't produce good user experience.

As i see there is no way to control palette from application. You either support dark mode or not. As a hack we can tweak Info.plist with NSRequiresAquaSystemAppearance to temporary disable support for dark mode. Also building with qt 5.12 can help. It should contains better support for dark mode.

[Former user]

To clarify. As things are right now, one cannot use Valentina if they use macOS Mojave in dark mode. They have to completely disable dark mode at the OS level and use the light interface on both to be able to work. Hence 'major' impact.

[Former user]

I don't advocate using Valentina's dark mode. As it's set up right now, I cannot use Valentina if I happen to have my OS set to dark mode. Hope this explains the problem better.

Perhaps the suggested tweak should be the default as it's an unexpected regression for Valentina users.

[Former user]

Confirmed, setting NSRequiresAquaSystemAppearance (Boolean) to YES is a workaround to the regression and allows me to use Valentina again.

[Roman Telezhynskyi]

Temporary workaround for issue with dark theme on MacOS. ref #922.

→ <<cset 330a7704f000>>

[Roman Telezhynskyi]

This repository has been archived. If you want to report a bug or your feature request, you need to do this in the new repository [https://gitlab.com/smart-pattern/valentina†(https://gitlab.com/smart-pattern/valentina). This issue ticket will be closed.