Extension no longer works (GA changed their DOM structure)

Issue #39 resolved
J S created an issue

This extension no longer works. Google Analytics changed their DOM and now embed all their content inside an iframe called "galaxyIframe". I looked at your inject.js and it looks like a fairly trivial changed to fix it.

Inside the 'updateDimensionData' function you could change the loop to do the following.

"$('td.ID-dimension-data-' + i, $('#galaxyIframe').contents()).each(function () {..."

I hacked at it briefly and verified that the above line will indeed add all the user names back in. It also looks like some css needs to be modified on the popover to make it pretty again.

If you open source the project I would be happy to hack at it more and do a pull request.

Comments (19)

  1. Martin Farmer Account Deactivated

    Just to confirm that I see the same issue, and agree with the proposed solution, along with the need to perform some minor presentation tidy up.

  2. David Simpson repo owner

    This looks like what I need to do. Looking at it now.

    The popover does indeed need a little CSS.

  3. Martin Farmer Account Deactivated

    @dvdsmpsn - Just a quick update - the updated version works great for google generated reports, but if I have a custom report with the same custom dimensions in, it fails to show the lookup data there....

  4. David Simpson repo owner

    @martinfarmer That's weird. I'm seeing custom reports working just fine. Here's an example:

    Screen Shot 2018-04-16 at 11.41.31.png

    Can you give me more of an idea please?

  5. Martin Farmer Account Deactivated

    Sure thing. Here is the viewer working (after the recent changes to 0.12):

    PII-viewer-working.png

    Notice the user id ending 916852b has the name (from your example csv file)

    now, here is my custom report:

    PII-viewer-not-working.png

    See the same user (In the UNIQUE_USER_ID column) has not been addressed by the viewer

  6. David Simpson repo owner

    @martinfarmer can you give me the html of the individual table cells that are missing the mapping, e.g.

     <td class="ID-dimension-data-0 _GAwr"><span class="_GApu ">ff808****0001</span></td>
    

    Perhaps you table cells have an interesting class name which I am missing. Also check whether it's still in an iframe#galaxyIframe

  7. Martin Farmer Account Deactivated

    Hi - This code is running version 0.12 - which I think is the latest. It fixed the issue with the "top events" report, as per the bug described by this report, but doesn't fix the custom report ?

  8. David Simpson repo owner

    I've just published v0.0.13 to Chrome Store. The extension should show up wiothin the hour.

    Try the update 👍

  9. David Simpson repo owner

    Its good that we're getting closer. Try the new v0.0.14 which should be available in the next few minutes to an hour. It has style fixes.

  10. J S reporter

    Just wanted to confirm that v0.0.14 is working. Thanks for the quick turnaround. You have made a lot of people very happy.

  11. Martin Farmer Account Deactivated

    v0.0.14 works great for the custom reports and the stock reports too (for me!)

  12. Log in to comment