Moodle 4.1 Glossary opens multiple windows

Issue #167 resolved
Patrice Robitaille created an issue

*DESCRIPTION*

This is a similar problem to issue #153 where the glossary opens multiple popup windows on click.

I this is actually only fixed for Moodle 4.2. Is this possible to fix this problem for Moodle 4.1 too?

OBSERVED BEHAVIOR:

In Moodle 4.1, when the glossary is active and clicking on words can open a popup, the popup open multiples times.

EXPECTED BEHAVIOR:

Click on a word to open a popup should only open one popup at a time.

Comments (9)

  1. David Watson repo owner

    Thanks for the report. There is a fix for this in the latest 4.3 release which is intended to roll out to 4.1/4.2 in coming weeks

  2. Vincent Schneider

    @David Watson It still seems to be happening in Moodle 4.1, has this change been rolled out in the latest version yet?

  3. David Watson repo owner

    @Vincent Schneider yes it has. Which version of the plugin are you using? The latest for 4.1 is 4.1.1.12 with another coming shortly

  4. Vincent Schneider

    @David Watson We have this issue in the version 4.1.1.12 from the https://moodle.org/plugins/format_tiles page. We have purged the cache but the issue still remains.

    This was tested in a moodle with the version 4.1.11+ (Build: 20240620), tested in Chrome 127.0.6533.100 (Offical Build) (64-Bit) and in Firefox 129.0 (64-Bit) under Windows 10.

    edit: Before the version update there could be more than 2 popups with one click. Now it seems to be always 2 but not more.

  5. David Watson repo owner

    @Vincent Schneider I cannot replicate that. Can you post a screen capture showing how you generate it? Is the auto link you are clicking in a page activity? I could not replicate that originally but now I notice that auto links within a page do indeed generate 2 x dialogues. I believe I have a fix for that.

    Also there is a core issue where, if you click the auto link more than once, it will generate a new dialogue for each click. In topics format, once the dialogue is open, it mostly obscures the link, making it hard for the user to click again. But in tiles it’s easier to do as the link is more visible even when the dialogue is open. (This is a separate issue to the one originally raised in this ticket and not one I have done anything about yet as I only noticed it today.)

    Finally, core keeps the dialogues on screen until dismissed. It may be better in tiles to remove them automatically if the user scrolls, closes the tile or opens another. I could add that to the plugin.

  6. Log in to comment