Display PDF issue on modal window with Safari with last versions of Tiles

[INALCO]

Dear David,

Thank you very much for this very successful course format on our Moodle. We've been using it for 4 years.

We have upgraded to Moodle 4.4 and are experiencing a problem displaying PDFs in modal windows with the Safari browser: the PDF does not display at all.
When we uncheck PDF in Modal resources, the direct link works.

Moodle 4.4.2
Theme: boost_union 4.4-R1 or classic
Tiles: 4.4.0.17 and 4.4.0.20
Safari: versions 13, 15 and 17

We have several Moodle platforms. There's no such bug on our 4.4.2 test platform with tiles 4.4.0.9

We think there's a bug in a version > 4.4.0.9 (but we don't know which one)

Can you help us?
Here are some screenshots.

Do you need more information?

Thanks in advance

Pascal

[David Watson]

Fixes issue #222 safari pdf modal

→ <<cset 47313b4e9ef9>>

[David Watson]

Thanks for the report Pascal. I have come up with a fix which will go into the next release. I deployed the fix to https://demo.evolutioncode.uk/course/view.php?id=5&section=5 where it seems to be working with Safari

[INALCO]

Thanks for the quick correction.
However, testing on your demo site: under Safari (13, 15 and 17) when we click 2x on the PDF: the bug reappears on the 2nd click.

Do you notice the same thing?

(Also, we've seen that the index on the left doesn't appear on Safari 13: but I can open a ticket for this other problem, which doesn't seem to be related to the bug).

[David Watson]

Thanks I checked that and it does work more than once for me. Can you describe exactly what you do for the second click? E.g. close modal, click again or close tile/refresh page etc

(With regard to the course index, I believe that is a Moodle core issue. For example I see the same thing at https://sandbox.moodledemo.net/ - do you? I suspect that Safari 13 was no longer current when the course index was introduced).

[INALCO]

Here's what we do:

• click on the PDF
• close the modal
• click again on the same PDF: it bugs

If you click on another PDF, the PDF is displayed. But if you close the modal and click on the same PDF again, it bugs.

If we refresh the page, we can click on the PDF : it appears but on the 2nd clic, it bugs.

I will make a video.

(Sorry for the course index, it is a Moodle core issue).

[David Watson]

Ok I see the issue. I will deploy the version I have for now but am re-opening to look at the 2nd launch point

[INALCO]

Thanks !
The video if needed : https://filesender.renater.fr/?s=download&token=50b38763-c55e-4bba-8d57-e54d8bfa6297

‌