Modal height bug when using iframes

[Philipp Memmel]

For pages opened in a modal containing an iframe whose height is bigger than the max height of the modal the last line is being cut off and the scroll bar isn’t fully visible:

PR incoming…

‌

[Philipp Memmel]

See https://bitbucket.org/dw8/moodle-format_tiles/pull-requests/9/fix-modal-min-height-for-modals-including

[tmw]

This is potentially related, so reporting here. I get double scroll bars when viewing a PDF in the modal (Firefox and Chrome), the outer scrollbar only moves the page by a few pixels.

Testing with Moodle 4.0.2 with Tiles version 4.0.0.2 Beta (I switched to the boost theme as well). This problem does not occur with Moodle 3.9.14 and Tiles v 3.11.1.3.

Unfortunately applying the fix from the previous post didn’t cure the problem.

[Philipp Memmel]

Hi @tmw, I rebased and combined the fix with another one and sent a PR for moodle 4.0 version. It works for me and I didn't do anything fancy, so it's a bit strange, that applying the patch does not work for you. Have you tried applying https://bitbucket.org/dw8/moodle-format_tiles/pull-requests/18?

[tmw]

The patch in pul request #18 seems to have done the trick, thankyou. Hopefully that will make it into the next full release.