- changed status to open
- removed comment
EOS_Omni: piecewise polytrope support with up to 10 pieces
The following pull-request should be looked at:
As described there, this includes:
Modification for work: Phys. Rev. D93, 064047 (2016), arXiv:1509.08804
Now it support hybrid EOS with up to ten pieces
Bug corrected on allocation of teh paramter set for back-compatibility
EOS_Omni: remove space
Note that the diff as shown on butbucket is mis-leading. It mixes parameter names and values in ways that easily lead to misunderstandings.
Keyword: parma
Comments (9)
-
reporter -
reporter - removed comment
-
reporter - removed comment
ping, I need a review.
-
- changed status to open
- removed comment
Comments are in the pull request. Basically: the code is fine, the physics as well (I had tested against another code and re-derived most of the expressions).
I am not sure if it should go in right away as it is unclear how much of a speed impact (for example) the loops over pieces have and also for the fact that this is a backwards incompatible change very shortly before the release. It does seem to introduce a handful of changes of behaviour which should not go into the ET without testing first.
-
- removed comment
Thanks for pointing out my misreading of the diff. I did not look carefully enough at it apparently. I re-shuffled the lines to make the diff simpler (which mixes old and new parameters, which I guess explains why the parameters were shuffled in the first place) and the only leftover comment is the one on poly_gamma_ini (and speed technically): https://bitbucket.org/einsteintoolkit/einsteineos/pull-requests/3/rhaas-parma/diff
-
- changed status to open
- removed comment
-
- changed status to open
- removed comment
After consultation and discussion: please apply.
-
- changed status to resolved
- removed comment
-
- edited description
- changed status to closed
- Log in to comment