check that all parfiles that set ADMMacros::spatial_order also set GRHydro::sources_spatial_order to the same value

Create issue
Issue #2120 closed
Roland Haas created an issue

Since GRHydro switched from ADMMacros to its own finite differencing for the Christoffels in the source term, we must make sure that the change was propagated to all parfiles. We may even want to check in GRHydro's paramcheck that, if ADMMacros is active its spatial_order parameter agrees with GRHydro's sources_spatial_order which should capture all legacy parfiles that need updating.

Keyword: GRHydro

Comments (13)

  1. Roland Haas reporter
    • removed comment

    To be included only after the release. Testing of course that all parfiles are correct should happen before the release.

  2. helvi witek

    I agree with your pull request.

    • Historically, has there been such a change from ADMMacros to thorn specific FD orders in other evolution thorns? If so, I would suggest to add a similar parameter check to those.
    • I suggest to change the relevant parameters in the gallery examples and tutorials to avoid this problem in the future. If no one objects I will do that in the TOV gallery example
  3. Roland Haas reporter

    Yes, all the gallery examples should be updated. In fact they should already be updated (see #2118 to some extend).

    What is currently not updated is the einsteinexamples repository which contains currently still the files that were used by the code at the time of paper writing.

    I do not think there has been such a change before though there may have been before I joined the ET.

  4. Roland Haas reporter

    Parfiles in EinsteinExamples updated in git hash 1f7de20 “use GRHydro::sources_spatial_order in examples using GRHydro“

  5. Roland Haas reporter

    Parfiles in EinsteinAnalysis update in git hash 7f075d92 “Hydro_Analysis: set GRHydro::sources_spatial_order in example parfile“

  6. Log in to comment