Fix small memory leak in Piraha

Create issue
Issue #2208 closed
Steven R. Brandt created an issue

This pull request

https://bitbucket.org/cactuscode/cactus/pull-requests/54/piraha-mem/diff

Fixes a small memory leak caused by a cyclic reference.

Keyword: None

Comments (5)

  1. Roland Haas
    • removed comment

    Steve and Roland discussed this in person at SC18. Roland asks to have the prototype of the constructor changed to take a bare pointer rather than a smart-pointer to make it more obvious for callers of the Lookup objects that they store a bare pointer to the their grammar.

    The current logic in piraha should be such that the grammar object exists for as long as the lookup objects exist so the pointer should not become dangling.

  2. Steven R. Brandt reporter
    • changed status to open
    • removed comment

    The pull request has been updated to address Roland's concern.

  3. Log in to comment