update hwloc included tarball to 2.0.1

[Roland Haas]

hwloc currently includes hwloc 1.11.12 from Dec 13, 2018 which is the “ultrastable” branch: https://www.open-mpi.org/software/hwloc/v1.11/

The MPI external library on the other hand includes version 2.0.1 as in its sources, and some package managers (homebrew, Debian) have updated to a 2.X version (stable).

Thus it may be good to update the included tarball to the same version (which the ExternalLibrary will then use when it is being compiled). This will break some thorns that use hwloc since 2.X is not API compatible with 1.X. The ET’s thorns support both versions of hwloc.

‌

[Roland Haas]

Pull request is here:

https://github.com/EinsteinToolkit/ExternalLibraries-hwloc/pull/1/files

Please review.

[Erik Schnetter]

I agree with this change, e.g. MPICH has hwloc 2.0.x built-in as well.

‌

I would use a later version of hwloc, e.g. 2.0.4. Presumably patch upgrades will only correct errors, which seems a good thing.

[Roland Haas]

I updated the tarball to 2.0.4 and (squash-)merged into master.

‌

[Roland Haas]

Applied as git hash 5155046 "hwloc: update included tarball to 2.0.1 (#1)" of ExternalLibraries-hwloc.

The commit message is misleading, apparently I did not edit the subject line when squash-merging via github. The version included is 2.0.4.

[Roland Haas]

it turns out SystemTopology failed with 2.0.X due to (likely) and incorrect assumption about how caches are "included" in each other. #2314 proposes to backport to fix to the release branch (Mayer). Master has been fixed already in git hash aacb23f "SystemTopology: list expected cache types instead of range checking" of cactusutils.

[Roland Haas]

The fix was backported.