review changes required for gcc-10 / gfortran-10 readyness

[Roland Haas]

These open tickets and their pull requests are required to compile and run testsuites with gcc-10/gfortran-10 and run on the set machines in the release notes:

• https://bitbucket.org/einsteintoolkit/tickets/issues/2403/compile-failure-with-gfortran-10-when
• https://bitbucket.org/einsteintoolkit/tickets/issues/2419/work-around-type-issues-in-varags-reduce
• https://bitbucket.org/einsteintoolkit/tickets/issues/2420/use-consistent-argument-types-in-eos_omni
• https://bitbucket.org/einsteintoolkit/tickets/issues/2429/make-externallibraries-hdf5-compile-with

These changes should be backported to the release code to support gcc-10 / gfortran-10:

• https://bitbucket.org/einsteintoolkit/tickets/issues/2403/compile-failure-with-gfortran-10-when
• https://bitbucket.org/einsteintoolkit/tickets/issues/2419/work-around-type-issues-in-varags-reduce
• https://bitbucket.org/einsteintoolkit/tickets/issues/2420/use-consistent-argument-types-in-eos_omni
• https://bitbucket.org/einsteintoolkit/tickets/issues/2429/make-externallibraries-hdf5-compile-with
• https://bitbucket.org/einsteintoolkit/tickets/issues/2406/cactus-fails-to-link-with-gcc-10-due-to
• https://bitbucket.org/einsteintoolkit/tickets/issues/2402/compiling-lapack-externalthorn-from-source

These changes should be backported at the same time since the address errors which were either discovered shortly before the release or have no known workaround

• https://bitbucket.org/einsteintoolkit/tickets/issues/2421/fix-misisng-initializating-and-incorrect
• https://bitbucket.org/einsteintoolkit/tickets/issues/2426/g-10-possibly-miscompiles-parts-of-carpet
• https://bitbucket.org/einsteintoolkit/tickets/issues/2427/release-tag-et_2020_05_v0-points-to-wrong
• https://bitbucket.org/einsteintoolkit/tickets/issues/2432
• https://bitbucket.org/einsteintoolkit/tickets/issues/2400
• https://bitbucket.org/einsteintoolkit/tickets/issues/2398/multipole-default-midpoint-integration

Release testsuite status:

http://einsteintoolkit.org/testsuite_results/index.php

[Roland Haas]

Please review.

[Roland Haas]

All required patches except https://bitbucket.org/einsteintoolkit/tickets/issues/2429/make-externallibraries-hdf5-compile-with have been applied to master.

The following issues have not been reviewed (at all) (and need to be) for backporting:

• https://bitbucket.org/einsteintoolkit/tickets/issues/2429/make-externallibraries-hdf5-compile-with
• https://bitbucket.org/einsteintoolkit/tickets/issues/2421/fix-misisng-initializating-and-incorrect
• https://bitbucket.org/einsteintoolkit/tickets/issues/2400/compiling-openblas-from-source-produces

‌

[Roland Haas]

Backported to ET_2020_05 as git hash 48adeff2 "Cactus: skip trying to find intrinsic module files" of cactus

Backported to ET_2020_05 as git hash 57490aa5 "EHFinder: explicitly convert void* pointers to addresses" of einsteinanalysis

Backported to ET_2020_05 as git hash 8c6fb23 "TestReduce: work around F77 compilers checking subroutine argument lists" of cactustest

Backported to ET_2020_05 as git hash f997985 "GRHydro: use consistent argument ranks for EOS_Omni calls" of einsteinevolve

Backported to ET_2020_05 as git hash 9f27e9d "HDF5: update included tarball to 1.12" of ExternalLibraries-HDF5

Backported to ET_2020_05 as as git hash 9a41374f "Cactus: use CCTK_ATTRIBUTE_COMMON for RESTRICTED params" of cactus

Backported to ET_2020_05 as git hash b18b135 "LAPACK: update tarball to 3.9.0" of ExternalLibraries-LAPACK

Applied as git hash 8fae77a "CT_Analytic: regenerate using Kranc e69182c" of ctthorns

Backported to ET_2020_05 as as git hash ee28813f "Multipole: implement correct midpoint rule" of einsteinanalysis