- changed component to Cactus
-
assigned issue to
VERSION option in configuration.ccl is overly restrictive in allowed characters
Issue #2552
resolved
I have a file configuration.ccl
like so:
# Configuration definitions for thorn CMake
PROVIDES CMake
{
SCRIPT src/detect.sh
LANG bash
VERSION 3.15.0
OPTIONS CMAKE_DIR CMAKE_INSTALL_DIR
}
and CST fails with:
CST error in /data/rhaas/postdoc/gr/cactus/CactusAMReX/arrangements/ExternalLibraries/CMake/configuration.ccl (at 7)
-> SYNTAX ERROR
HINT: ERROR ON LINE 7:
SCRIPT src/detect.sh
LANG bash
VERSION 3.15.0
^
| here
FOUND CHARACTER: '.'
EXPECTED CHARACTER(S): '-', '0' to '9', 'A' to 'Z', '\', '_', 'a' to 'z', '}'
ie the dot “.” is not allowed in version strings. Since these were modeled (somewhat) after Debian version numbers, here’s an example of one of those 2:3.6.19-1~bpo70+1+b1
and https://manpages.debian.org/buster/dpkg-dev/deb-version.7.en.html for their definition (upstream version could be any string, really).
Comments (8)
-
reporter -
reporter Pull request
https://bitbucket.org/cactuscode/cactus/pull-requests/132/cactus-allow-all-of-a-za-z0-9_-in-version
contains a proposed fix.
-
reporter - changed status to open
-
reporter Please review.
-
Approved.
-
reporter Thank you.
-
reporter -
reporter - changed status to resolved
- Log in to comment