SummationByParts does not ensure unique gobal function names

[Roland Haas]

@tootle reported an issue on the mailing list: http://lists.einsteintoolkit.org/pipermail/users/2023-February/008840.html

(One of the) underlying issues is that SummationByParts does not prefix the (globally visible) Fortran subroutines with the SBP_ prefix it uses (and must use) for globally visible symbols.

This also makes CCTK_FNAME fail due to incorrect usage (the name it acts on must have mixed case).

[Roland Haas]

Pull request for SummationByParts is here: https://bitbucket.org/cactuscode/cactusnumerical/pull-requests/20

[Roland Haas]

Please review.

[Roland Haas]

@Peter Diener any updates on the review?

[Roland Haas]

@Peter Diener any updates on the review?

[Roland Haas]

Peter pointed out that the corresponding change in Llama/GlobalDerivatives (in the ET) will be needed as well. Pull request is https://bitbucket.org/llamacode/llama/pull-requests/9

Peter says please apply.

[Roland Haas]

Applied as git hash 3733ef5 "GlobalDerivate: adapt to subroutine change in SummationByPart" of llama
Applied as git hash c1d60d24 "SummationByParts: add thorn name to globally visible F90 routines" of cactusnumerical

[Roland Haas]

Thank you @Peter Diener