Make Seed_Magnetic_Fields independent of IllinoisGRMHD
Seed_Magnetic_Fields schedules its functions with respect to IllinoisGRMHD, which is an unnecessary dependency since this thorn only depends on HydroBase. Changing this scheduling would allow for other thorns to use it, as currently its scheduling would be very unpredictable without IllinoisGRMHD scheduled.
Additionally, this update merges the features of wvuthorns_diagnostics/Seed_Magnetic_Fields_BNS into this thorn. The BNS variant thorn will be deprecated to be removed in the ET_2024_05 release. There is no need for separate thorns, and this merge serves to unify their scheduling and general behavior, since they currently do not behave in the same way and would likely confuse those attempting to use them with a thorn other than IllinoisGRMHD.
Comments (4)
-
reporter -
reporter The associated PR: https://bitbucket.org/zach_etienne/wvuthorns/pull-requests/14
-
reporter - attached diff_clean.txt
- attached diff.txt
Attached a raw diff of the original Seed_Magnetic_Fields_BNS function against the function in the branch. Additionally, I included
diff_clean.txt
where I clean up the pairing of lines so it is easier to see what the differences actually are. Many of the changes were to standardize the formatting between this function and the TOV function. -
reporter - changed status to resolved
This was merged and included in the ET_2023_11 release.
- Log in to comment
@Zach Etienne is the reviewer for this update, to be included in the ET_2023_11 release.