- removed comment
GetComponents hangs when "svn info" reports a certificate warning
Issue #752
closed
This is similar to, but not the same as, #135. The problem is that GetComponents runs "svn info" on a repository with https where SVN thinks the certificate is not valid:
MacBook-2:manifest (master) $ svn info --username hinder https://svn.cactuscode.org/arrangements/CactusNumerical/MoL/device
Error validating server certificate for 'https://svn.cactuscode.org:443':
- The certificate is not issued by a trusted authority. Use the
fingerprint to validate the certificate manually!
Certificate information:
- Hostname: svn.cactuscode.org
- Valid: from Thu, 05 Jan 2012 21:31:52 GMT until Fri, 04 Jan 2013 21:31:52 GMT
- Issuer: lsu, edu
- Fingerprint: d1:ea:8a:9a:a8:7d:a5:15:7a:56:22:27:99:30:96:d7:e4:38:0e:53
(R)eject, accept (t)emporarily or accept (p)ermanently?
This causes GetComponents to hang permanently with no indication of what is wrong. The solution to #135 was to add --non-interactive to the "svn update" command, and "svn info" also supports such an option. Should it be added here as well?
Keyword:
Comments (4)
-
-
- changed status to open
- removed comment
-
- changed status to resolved
- changed milestone to ET_2012_05
- removed comment
-
- changed status to closed
- edited description
- Log in to comment
Does the following patch help with this problem?
--- a/GetComponents +++ b/GetComponents @@ -1289,7 +1289,7 @@ sub handle_svn {
elsif ( $method eq 'authenticate' ) {
- $cmd = "$svn info $user $url"; + $cmd = "$svn info --non-interactive $user $url"; $err = run_command($cmd);
elsif ( $method eq 'verify_url' ) { my $dir = defined($name) ? $name : $checkout; - my $cmd = "$svn info --xml $target/$dir"; + my $cmd = "$svn info --non-interactive --xml $target/$dir";
my $same_url; my $new_url = $url;