- changed status to open
RNDF integration into Drake
Log the progress of the PR so as to track it.
Comments (23)
-
reporter -
reporter First PR contains only the RoadGeometry implementation without tests Builder and Loader classes. --> https://github.com/RobotLocomotion/drake/pull/6198
A second PR will contain, probably the Builder.
A third PR, the Loader + sample maps.
This was sketched up with Stonier and Liang.
-
reporter -
reporter Addressed comments of the second round of feature review. For the record, we should both compile with bazel and with cmake. When running cmake, I recommend calling it like:
#! env CC=gcc-4.9 CXX=g++-4.9 FC=gfortran-4.9 cmake -DCMAKE_BUILD_TYPE:STRING=Debug -DUSE_INCLUDE_WHAT_YOU_USE:BOOL=ON -DUSE_LINK_WHAT_YOU_USE:BOOL=ON -DUSE_SANITIZER=Address ..
You can use another option for
USE_SANITIZER
based on your needs. Nevertheless this may satisfy most of our needs. See this link for more details.Something useful too, is to run
clang-format
. AFAIK it's not integrated into bazel / cmake / git-hook so it should be done manually. See this link for more details. -
reporter Moved to feature-review stage.
-
reporter First PR was merged.
-
reporter New PR with spline helpers: https://github.com/RobotLocomotion/drake/pull/6256
-
reporter - changed component to Gazebo
-
reporter - changed component to Drake
-
reporter Received feedback on the last PR. Need to address changes for it.
-
reporter - changed status to on hold
-
reporter Sent corrections to the first pass of reviews.
-
reporter Sent corrections to the second pass of reviews.
-
reporter After addressing third review, we need to move to the platform-review.
-
reporter - changed status to open
-
reporter Second PR merged. Sent updates regarding spline comparison. Here is the summary of the research.
-
reporter Start to code third PR.
Here it is: https://github.com/RobotLocomotion/drake/pull/6349
-
reporter Adressed comments for third PR.
-
reporter New comments have been addressed.
-
reporter After a couple of comments, we moved on to pĺatform review stage.
-
reporter A spin of has been created. We need to first create a refactor on Monolane and RNDF implementations of Maliput and promote them to Maliput so we reduce code duplicates.
-
reporter PR merged. Consequently I'm going to rebase code into https://github.com/RobotLocomotion/drake/pull/6349
-
reporter New PR released. https://github.com/RobotLocomotion/drake/pull/6569
- Liang did a first pass and we addressed those comments. Doxygen documentation issue couldn't be resolved. We shared our tests with him so as to solve them with him.
- Log in to comment