- changed status to on hold
Refactor GetWaypointByUniqueId method
Refactor GetWaypointByUniqueId so it uses the Waypoint pointer built in RNDFNode class. It will improve overall performance as this is provided in the new version of Manifold.
Comments (9)
-
reporter -
- changed status to new
-
- changed status to on hold
-
-
assigned issue to
-
assigned issue to
-
- changed status to new
-
@agalbachicar could you be more specific?
-
reporter We should change the code in https://bitbucket.org/ekumen/terminus-simulation/src/045452145fc1b267a1fea29afbf80f3f5cbacf77/gazebo/rndf_gazebo_plugin/src/dynamic_render.cc?at=master&fileviewer=file-view-default#dynamic_render.cc-405 to make use of the changes introduced in https://bitbucket.org/osrf/manifold/commits/f82a77f5d7de89af9c227eea42c91581d22a5cfc.
Specifically, instead of searching the waypoints inside the lane, we can retrieve the pointer directly from the RNDFNode.
Also we can include GetTypeFromVertex( std::shared_ptr<ignition::math::Vertex<std::string>> vertex) and tidy up the waypoint type check.
-
reporter - changed status to open
-
reporter - changed status to resolved
Fixes
#75. Refactors DynamicRender::GetTypeFromVertex and DynamicRender::GetWaypointByUniqueId to make better use of manifold data structures→ <<cset 5627e0018a60>>
- Log in to comment