Broken bytecode when using Java 8 return type inference

Issue #229 resolved
Jesper Öqvist created an issue

ExtendJ 8.0.1-229-g3f4f983 Java SE 8

There is an error in code generation for the following test case:

// This was adapted from a Stack Overflow question:
// Both method calls should bind to the String argument method.
// .result: EXEC_PASS
public class Test {
  public static void main(String[] args) {

  static void method(String v) {

  static void method(Object v) {

  interface I {

  static <T extends I> T get() {
    return null;

Expected result: no runtime problems.

Actual result: runtime exception:

    [junit] [FAIL] runTest[jsr335/inference/method_07p](tests.extendj.TestJava7)
    [junit] Error output files differ expected:<[]> but was:<[Error: A JNI error has occurred, please check your installation and try again
    [junit] Exception in thread "main" java.lang.NoClassDefFoundError: wildcards/& java/lang/String& Test/I
    [junit]     at java.lang.Class.getDeclaredMethods0(Native Method)
    [junit]     at java.lang.Class.privateGetDeclaredMethods(
    [junit]     at java.lang.Class.privateGetMethodRecursive(
    [junit]     at java.lang.Class.getMethod0(
    [junit]     at java.lang.Class.getMethod(
    [junit]     at sun.launcher.LauncherHelper.validateMainClass(
    [junit]     at sun.launcher.LauncherHelper.checkAndLoadMain(
    [junit] Caused by: java.lang.ClassNotFoundException: wildcards.& java.lang.String& Test.I
    [junit]     at
    [junit]     at java.lang.ClassLoader.loadClass(
    [junit]     at sun.misc.Launcher$AppClassLoader.loadClass(
    [junit]     at java.lang.ClassLoader.loadClass(
    [junit]     ... 7 more]>

Comments (5)

  1. Jesper Öqvist reporter

    The method invocations are correct, but the checkcast generated before the second invocation is broken:

             0: ldc           #20                 // String 
             2: invokestatic  #24                 // Method method:(Ljava/lang/String;)V
             5: invokestatic  #28                 // Method get:()LTest$I;
             8: checkcast     #30                 // class "wildcards/& java/lang/String& Test/I"
            11: invokestatic  #24                 // Method method:(Ljava/lang/String;)V
  2. Jesper Öqvist reporter

    Improve checkcast generation

    Fixed several cases where redundant checkcast instructions could be generated. This is done by moving the casting operation from where the expression value is evaluated, to the context where it is used.

    Also fixed incorrect casts by using the erased source type to decide if a cast is needed.

    Future work: look over casts in AssignExpr.createBCode, Unary.emitPostfix, and Unary.emitPrefix.

    fixes #230 (bitbucket) fixes #229 (bitbucket)

    → <<cset b654375798b4>>

  3. Jesper Öqvist reporter

    Redesign typecasting code generation

    Removed casting conversions directly after method invocation and field loading. Instead, casting is now handled in the context where a field or method is used.

    Added method Expr.emitCastTo(, ) to handle type conversion from an expression to an expected type.

    Added method Expr.emitAssignConvTo(, ) to handle assignment conversion from an expression to an expected type.

    Added attribute Expr.erasedType(), for computing the erased runtime type of an expression.

    fixes #229 (bitbucket) fixes #230 (bitbucket)

    → <<cset 738074c49cbc>>

  4. Log in to comment