warning: logical not is only applied to the left hand side of comparison
Issue #22
resolved
This definitely looks like a bug:
/home/nschloe/software/moab/source-upstream/src/TupleList.cpp: In member function ‘int moab::TupleList::find(unsigned int, realType)’:
/home/nschloe/software/moab/source-upstream/src/TupleList.cpp:344:16: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
if (!key_num > mr)
Comments (3)
-
-
- changed status to resolved
-
- Log in to comment
yes, thanks for pointing it out. the good news is that the method is not exercised, as we are never finding a tuple from an exact real value. (for reals we use comparison with a tolerance, not "exact")
Of course, the bad news is that the method is not exercised :)