Tried to use module skinner and got error

[Ricardo Lira]

I tried to reproduce the test file in MOAB / pymoab / tests / test_skinner.py and none of them worked. It keeps returning me a MOAB_TAG_NOT_FOUND error.

[Vijay M]

Can you please provide more information about your case ? Is test_skinner failing ? @pshriwise

[Ricardo Lira]

Sure!

I literally Ctrl+C Ctrl+V the test file test_skinner.py and ran it. Skinner does not recognize the root set tag (which by default is '0' if Iḿ not wrong) and returns a tag error whenever I try to use the method find_geometric_skin(). Hope this is enough info.

[Patrick Shriwise]

Hi! Thank you for bringing this to our attention.

Looking at the test_skinner.py file, it seems that the test using find_geometric_skin is currently commented out of the unit test suite. We'll take a look at that soon.

As for the error your experiencing when using find_geometric_skin, this method relies on some 2D elements of the mesh being part of a geometric meshset, meaning a meshset tagged with the GEOM_DIMENSION_TAG. (This is probably where the error is coming from in that test, that tag doesn't exist). If you're looking to skin a mesh which doesn't contain any embedded geometric information, then the find_skin method will hopefully get the job done.

I hope I'm not telling you information you already know :) I'm just hoping to provide information to keep your project moving while we sort this out.

[Vijay M]

@pshriwise Do you have time to check this ? I'm swamped this week but if you can't get to this by next Tuesday, I'll have time after that.

[Patrick Shriwise]

I think I was in the process of doing so... starting with updating the test. I'll get back to that in the next couple of days.

[Ricardo Lira]

Hey guys, whats up? Any development on this issue? Many thanks!

[Patrick Shriwise]

Sorry for the delay. Quickly, what version of Python are you using?

[Ricardo Lira]

I'm using python 3.x

[Patrick Shriwise]

I think I've taken care of this issue. Please see pull request #398 for more information. Thank you again for bringing this to our attention!

[Vijay M]

Merge remote-tracking branch 'pshriwise/pymoab_skinner_fix' into develop

PR #398: This PR addresses issue #87 related to the pymoab skinner test failure.

I've just un-commented this tests and added a little extra geometry setup here to satisfy the expectations of find_geometric_skin.

Re-enabling a pymoab skinner test. Also adding to the test setup. Updating expected results of skinner test as a result of added geometry setup.

→ <<cset 5a28389f9a48>>

[Vijay M]

@pshriwise PR #398 is merged. Can we close this issue ?

[Patrick Shriwise]

Yeah it can go.