SCOTCH v6 not properly detected by CMake if DOLFIN_SKIP_BUILD_TESTS is set

[Chris Richardson]

FindSCOTCH.cmake should check for SCOTCH_VERSION >=6 and adjust the list of included libraries, regardless of whether it runs the build tests or not.

[Prof Garth Wells]

Is there an easy fix for this that can be made before the 1.4 release?

[Chris Richardson]

I've made a patch but it would be good for someone else to look at it.

[Johannes Ring]

The patch looks good and works fine on my computer.

[Chris Richardson]

@johannes_ring If you have time to merge into next that would be great.

[Prof Garth Wells]

It's already in next.

[Chris Richardson]

!!! OK, good...

[Prof Garth Wells]

Fix committed in a7cc779

[Chris Richardson]

This failed for me when compiling with SCOTCH downloaded by PETSc. I think it should check for ptscotch.h not scotch.h

[Johannes Ring]

Look for SCOTCH version number in ptscotch.h instead of scotch.h (fixes issue #253).

→ <<cset 41c5bcce2693>>

[Johannes Ring]

Revert "Look for SCOTCH version number in ptscotch.h instead of scotch.h (fixes issue #253)."

This reverts commit 41c5bcce26939fe123433f412b87ac5a37e14367.

→ <<cset 2c00d40e3e69>>

[Johannes Ring]

@chris_richardson - Why should it check for ptscotch.h instead of scotch.h?

[Chris Richardson]

I guess it is because you can build PETSc with ptscotch but not scotch... It was crashing for me because I didn't have scotch.h

[Johannes Ring]

Fix version detection for SCOTCH (fixes issue #253).

→ <<cset 4c1081f40c19>>

[Prof Garth Wells]

Removing milestone: 1.5 (automated comment)